feat: python multipart #943
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
33
to
36
| data['responseStatusCode'] = int(data.get('responseStatusCode', 0)) | ||
| data['duration'] = float(data.get('duration', 0)) | ||
| data['responseBody'] = cls.from_string(data.get('responseBody', '')) | ||
| return data |
There was a problem hiding this comment.
@loks0n are people able to then do response.responseBody.toJSON() or response.responseBody.toBinary() for example ?
There was a problem hiding this comment.
to_json() and to_binary() but yeah
| @@ -0,0 +1,96 @@ | |||
| import os | |||
There was a problem hiding this comment.
@loks0n I'm pretty sure we need changes in the service.py especially in the functions for createFile, createDeployment and createExecution to use the new payload class.
Please test these and let me know.
Co-authored-by: Christy Jacob <christyjacob4@gmail.com>
…to feat-python-multipart
tests/languages/ruby/plan.ts
Outdated
There was a problem hiding this comment.
@loks0n I think we can remove this?
christyjacob4
approved these changes
Aug 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.