Merge pull request #1244 from appwrite/chore-wrap-optional-python

fix: wrap non required values with Optional[] in python

Author: abnegate

src/SDK/Language/Python.php

@@ -235,32 +235,48 @@ public function getFiles(): array
      */
     public function getTypeName(array $parameter, array $spec = []): string
     {
+        $typeName = '';
+
         if (isset($parameter['enumName'])) {
-            return \ucfirst($parameter['enumName']);
-        }
-        if (!empty($parameter['enumValues'])) {
-            return \ucfirst($parameter['name']);
+            $typeName = \ucfirst($parameter['enumName']);
+        } elseif (!empty($parameter['enumValues'])) {
+            $typeName = \ucfirst($parameter['name']);
+        } else {
+            switch ($parameter['type'] ?? '') {
+                case self::TYPE_FILE:
+                    $typeName = 'InputFile';
+                    break;
+                case self::TYPE_NUMBER:
+                case self::TYPE_INTEGER:
+                    $typeName = 'float';
+                    break;
+                case self::TYPE_BOOLEAN:
+                    $typeName = 'bool';
+                    break;
+                case self::TYPE_STRING:
+                    $typeName = 'str';
+                    break;
+                case self::TYPE_ARRAY:
+                    if (!empty(($parameter['array'] ?? [])['type']) && !\is_array($parameter['array']['type'])) {
+                        $typeName = 'List[' . $this->getTypeName($parameter['array']) . ']';
+                    } else {
+                        $typeName = 'List[Any]';
+                    }
+                    break;
+                case self::TYPE_OBJECT:
+                    $typeName = 'dict';
+                    break;
+                default:
+                    $typeName = $parameter['type'];
+                    break;
+            }
         }
-        switch ($parameter['type'] ?? '') {
-            case self::TYPE_FILE:
-                return 'InputFile';
-            case self::TYPE_NUMBER:
-            case self::TYPE_INTEGER:
-                return 'float';
-            case self::TYPE_BOOLEAN:
-                return 'bool';
-            case self::TYPE_STRING:
-                return 'str';
-            case self::TYPE_ARRAY:
-                if (!empty(($parameter['array'] ?? [])['type']) && !\is_array($parameter['array']['type'])) {
-                    return 'List[' . $this->getTypeName($parameter['array']) . ']';
-                }
-                return 'List[Any]';
-            case self::TYPE_OBJECT:
-                return 'dict';
-            default:
-                return $parameter['type'];
+
+        if (!($parameter['required'] ?? true) || ($parameter['nullable'] ?? false)) {
+            return 'Optional[' . $typeName . ']';
         }
+
+        return $typeName;
     }
 
     /**

templates/python/package/client.py.twig

@@ -57,8 +57,6 @@ class Client:
         if params is None:
             params = {}
 
-        params = {k: v for k, v in params.items() if v is not None}  # Remove None values from params dictionary
-
         data = {}
         files = {}
         stringify = False

templates/python/package/services/service.py.twig

@@ -1,5 +1,5 @@
 from ..service import Service
-from typing import List, Dict, Any
+from typing import List, Dict, Any, Optional
 from ..exception import AppwriteException
 from appwrite.utils.deprecated import deprecated
 {% set added = [] %}