Add a route to show user targets #712
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
stnguyen90
force-pushed
the
feat-auth-user-targets
branch
from
f646097 to
4f8dfe7
Compare
stnguyen90
requested review from
chenparnasa
and removed request for
TorstenDittmann
|
@chenparnasa, you okay with going forward with this, for now? |
2 tasks
There's some code for creating a target, but it must go through design first.
stnguyen90
force-pushed
the
feat-auth-user-targets
branch
from
4f8dfe7 to
5019d4c
Compare
We must pass undefined because the server won't accept an empty string. Undefined will make the server use the default value, which is an empty string.
Allow empty topic descriptions
Don't allow filtering on userName since the attribute isn't in the collection to be filtered. Allow filtering on type since it is available and it would be userful. Change $createdAt type to datetime to allow filtering by greater/less than.
stnguyen90
commented
Jan 17, 2024
Comment on lines
+49
to
+64
| const promisesById: Record<string, Promise<any>> = {}; | ||
| targets.targets.forEach((target) => { | ||
| if (target.providerId && !promisesById[target.providerId]) { | ||
| promisesById[target.providerId] = sdk.forProject.client.call( | ||
| 'GET', | ||
| new URL( | ||
| `${sdk.forProject.client.config.endpoint}/messaging/providers/${target.providerId}` | ||
| ), | ||
| { | ||
| 'X-Appwrite-Project': sdk.forProject.client.config.project, | ||
| 'content-type': 'application/json', | ||
| 'X-Appwrite-Mode': 'admin' | ||
| } | ||
| ); | ||
| } | ||
| }); |
There was a problem hiding this comment.
Fetching providers here because Jake said:
Any way the API does this will be exceedingly heavy-handed, since there are likely to be only a few providers but many targets, can we use a memory-map and just fetch ones into it as they're missing while iterating targets?
…ibers Update filterable subscriber columns
Message is nested in data and isn't an attribute so it can't be queried.
This was referenced Jan 17, 2024
Merged
Merged
TorstenDittmann
merged commit 77d5482
into
fix-create-provider-enabled
1 of 4 checks passed
This was referenced Feb 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add a route to show user targets
There's some code for creating a target, but it must go through design first.
Test Plan
Manual
Related PRs and Issues
Parent:
Child:
Have you read the Contributing Guidelines on issues?
Yes