Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Form Field widget standardisation #9136

Open
18 of 35 tasks
riodeuno opened this issue Nov 12, 2021 · 1 comment
Open
18 of 35 tasks

[Feature] Form Field widget standardisation #9136

riodeuno opened this issue Nov 12, 2021 · 1 comment
Assignees
Labels
Enhancement New feature or request Needs PRD Issue which are awaiting PRD Property Pane Issues related to the behaviour of the property pane UI Building Product Issues related to the UI Building experience Widget Property Issues related to adding / modifying widget properties across widgets Widgets & Accelerators Pod Issues related to widgets & Accelerators Widgets Product This label groups issues related to widgets

Comments

@riodeuno
Copy link
Contributor

riodeuno commented Nov 12, 2021

Is there an existing issue for this?

  • I have searched the existing issues

Summary

Acheive predictable grouping and set of properties in all the Form field widgets

  • Input Widget
  • DatePicker Widget
  • Switch Widget
  • FilePicker Widget
  • Select Widget
  • Multi-select Widget
  • Checkbox Widget
  • RadioGroup Widget
  • TreeSelect Widget
  • Multi-TreeSelect Widget
  • Audio Recorder Widget
  • RichTextEditor Widget
  • Rate Widget
  • CheckboxGroup Widget

A few potential issues to note,

  • Padding is inconsistent between CheckboxGroup and Checkbox Widget
  • Labels are only available in InputWidget, TreeSelect Widget, Multi Tree Select Widget
  • Position of labels are different in InputWidget and (Multi)TreeSelectWidget
  • Inconsistent popovers between Multi and Tree Select Widgets

Common list of properties in a general form field component

  • defaultValue
  • onChange/onValueChange
  • Label
  • onKeyPress
  • isVisible
  • isRequired
  • isDisabled
  • ValidationFn
  • Tooltip (Helper Text)
  • Tooltip (Error)
  • onFocus
  • onBlur
  • Label Styles and or field styles

Why should this be worked on?

  • It is hard to consistently find properties as they lack predictable grouping
  • Some properties are missing in widgets, which should ideally have them
  • Alignment and such concerns arise if the padding and UI are not consistent

Screenshot 2021-11-12 at 3 08 28 PM

@somangshu
Copy link
Contributor

This is mix of changes related to property pane and widget components, We have two projects upcoming which this can be a part of:

  • Widgets styling
  • Property Pane controls ( UI )

We need to take a call to fix this under one scope

@Nikhil-Nandagopal Nikhil-Nandagopal changed the title [Feature][Epic] Form Field widget standardisation [Feature] Form Field widget standardisation Dec 17, 2021
@Nikhil-Nandagopal Nikhil-Nandagopal added Property Pane Issues related to the behaviour of the property pane Widget Property Issues related to adding / modifying widget properties across widgets labels Dec 17, 2021
@github-actions github-actions bot added Widgets Product This label groups issues related to widgets UI Building Product Issues related to the UI Building experience UI Building Pod labels Dec 17, 2021
@somangshu somangshu added the Needs PRD Issue which are awaiting PRD label Jan 13, 2022
@somangshu somangshu assigned dilippitchika and vuiets and unassigned somangshu Jan 13, 2022
@Nikhil-Nandagopal Nikhil-Nandagopal added the Widgets & Accelerators Pod Issues related to widgets & Accelerators label Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request Needs PRD Issue which are awaiting PRD Property Pane Issues related to the behaviour of the property pane UI Building Product Issues related to the UI Building experience Widget Property Issues related to adding / modifying widget properties across widgets Widgets & Accelerators Pod Issues related to widgets & Accelerators Widgets Product This label groups issues related to widgets
Projects
None yet
Development

No branches or pull requests

7 participants