Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] MultiSelect Default Value return value is not string. #7872

Closed
hiteshjoshi opened this issue Sep 27, 2021 · 2 comments · Fixed by #7895
Closed

[Bug] MultiSelect Default Value return value is not string. #7872

hiteshjoshi opened this issue Sep 27, 2021 · 2 comments · Fixed by #7895
Assignees
Labels
Bug Something isn't working Critical This issue needs immediate attention. Drop everything else MultiSelect Widget Issues related to MultiSelect Widget Needs automation Issues that needs automated tests Production TestGap Issues identified for test plan improvement Verified When issue is retested post its fixed Widgets Product This label groups issues related to widgets

Comments

@hiteshjoshi
Copy link

Description

The expected structure of multi select values are Array<{ "label": "string", "value": "string" }> and if we do INT and FLOAT on the value part the widget automatically converts it to string.
The same is not being followed on Default value. For e.g. if I put INT or FLOAT on default value, it doesn't automatically converts to string.

Behaviour of data type across the widget should have same expected results.

Screenshot 2021-09-27 at 9 02 43 PM

Steps to reproduce the behaviour:

Add steps to reproduce this behaviour, include console / network logs & screenshots

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See error

Important Details

  • Version: [Cloud / Self-Hosted vx.x]
  • OS: [e.g.MacOSX]
  • Browser [e.g. chrome, safari]
  • Environment [production, release, deploy preview]
@hiteshjoshi hiteshjoshi added Bug Something isn't working Widgets Product This label groups issues related to widgets Low An issue that is neither critical nor breaks a user flow MultiSelect Widget Issues related to MultiSelect Widget labels Sep 27, 2021
@somangshu somangshu assigned Tooluloope and unassigned somangshu Sep 27, 2021
@somangshu somangshu added Critical This issue needs immediate attention. Drop everything else hotfix and removed Low An issue that is neither critical nor breaks a user flow labels Sep 28, 2021
@somangshu
Copy link
Contributor

@Tooluloope @SatishGandham this is happening in case of the select widget too. The widget need to accept both string and int value, This failed because of a change in #7698, We need to make sure how to cover the cases here.

@SatishGandham
Copy link
Contributor

We are reverting the validation changes and continue to support numbers and boolean values.

@close-label close-label bot added the QA Needs QA attention label Sep 28, 2021
@vivekverma2312 vivekverma2312 added Verified When issue is retested post its fixed and removed QA Needs QA attention labels Sep 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Critical This issue needs immediate attention. Drop everything else MultiSelect Widget Issues related to MultiSelect Widget Needs automation Issues that needs automated tests Production TestGap Issues identified for test plan improvement Verified When issue is retested post its fixed Widgets Product This label groups issues related to widgets
Projects
None yet
Development

Successfully merging a pull request may close this issue.

9 participants