[Feature] Create app flow should use the latest dsl version

[hetunandu]

Summary

When the client does not send a DSL for app creation, the server falls back to using an old default DSL. This causes an updated layout right after the app is created. Instead, the client should send a DSL with the latest version number to avoid this migration later on

Motivation

Improve testability, avoid unnecessary update calls, improve load time performance on new apps

[sharat87]

@hetunandu, what do you think about updating the default DSL in the backend itself, instead of having the client send the initial DSL on every create-application request?

It appears to be pointing at version 4 currently:

appsmith/app/server/appsmith-server/src/main/java/com/appsmith/server/constants/FieldName.java

Lines 38 to 58 in 0d106a5

	public static String DEFAULT_PAGE_LAYOUT = "{\n" +
	" \"widgetName\": \"MainContainer\",\n" +
	" \"backgroundColor\": \"none\",\n" +
	" \"rightColumn\": 1224,\n" +
	" \"snapColumns\": 16,\n" +
	" \"detachFromLayout\": true,\n" +
	" \"widgetId\": \"0\",\n" +
	" \"topRow\": 0,\n" +
	" \"bottomRow\": 1254,\n" +
	" \"containerStyle\": \"none\",\n" +
	" \"snapRows\": 33,\n" +
	" \"parentRowSpace\": 1,\n" +
	" \"type\": \"CANVAS_WIDGET\",\n" +
	" \"canExtend\": true,\n" +
	" \"dynamicBindingPathList\": [],\n" +
	" \"version\": 4,\n" +
	" \"minHeight\": 1292,\n" +
	" \"parentColumnSpace\": 1,\n" +
	" \"leftColumn\": 0,\n" +
	" \"children\": []\n" +
	"}";

[hetunandu]

@hetunandu, what do you think about updating the default DSL in the backend itself, instead of having the client send the initial DSL on every create-application request?

It appears to be pointing at version 4 currently:

appsmith/app/server/appsmith-server/src/main/java/com/appsmith/server/constants/FieldName.java

Lines 38 to 58 in 0d106a5

	public static String DEFAULT_PAGE_LAYOUT = "{\n" +
	" \"widgetName\": \"MainContainer\",\n" +
	" \"backgroundColor\": \"none\",\n" +
	" \"rightColumn\": 1224,\n" +
	" \"snapColumns\": 16,\n" +
	" \"detachFromLayout\": true,\n" +
	" \"widgetId\": \"0\",\n" +
	" \"topRow\": 0,\n" +
	" \"bottomRow\": 1254,\n" +
	" \"containerStyle\": \"none\",\n" +
	" \"snapRows\": 33,\n" +
	" \"parentRowSpace\": 1,\n" +
	" \"type\": \"CANVAS_WIDGET\",\n" +
	" \"canExtend\": true,\n" +
	" \"dynamicBindingPathList\": [],\n" +
	" \"version\": 4,\n" +
	" \"minHeight\": 1292,\n" +
	" \"parentColumnSpace\": 1,\n" +
	" \"leftColumn\": 0,\n" +
	" \"children\": []\n" +
	"}";

I think both client and server should have the latest DSL copy but since all DSL version updates originate because of client side changes, I think it is better that a client sends this when creating an app

[sharat87]

Then may be we can remove the server side hard-coded DSL completely? My take is that either we keep it updated regularly, and use it for new applications, or remove it and let the client send a DSL for new applications. Keeping a copy on both places will add overhead of keeping them updated and in-sync, with no value-addition.