Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: [HTML Column Type - Table] One uncommitted change seen on navigating to html column type cell url and getting back to page #38310

Open
1 task done
btsgh opened this issue Dec 23, 2024 · 5 comments
Assignees
Labels
Bug Something isn't working Git Product Issues related to version control product High This issue blocks a user from building or impacts a lot of users Needs Triaging Needs attention from maintainers to triage Packages & Git Pod All issues belonging to Packages and Git Release Table Widget V2 Issues related to Table Widget V2 Widgets & Accelerators Pod Issues related to widgets & Accelerators Widgets Product This label groups issues related to widgets

Comments

@btsgh
Copy link
Collaborator

btsgh commented Dec 23, 2024

Is there an existing issue for this?

  • I have searched the existing issues

Description

One uncommitted change seen on navigating to html column type cell url and getting back to page

Steps To Reproduce

  1. Create a git connected app, and generate page with data with mongo movies database
  2. For the homepage column, change it to type html and paste this code:
    <a href = {{currentRow["homepage"]}}> Link to Home page of this movie
  3. Commit these changes
  4. Create a branch from master
  5. Now click on a link on one of the cell of the homepage column
  6. It will take user to a valid page
  7. Click back to get back to the appsmith app edit mode
  8. Now click on the plus icon and note that there is an uncommitted change, though we have not changed the app / page in the edit mode
Screenshot 2024-12-23 at 1 54 38 PM

https://jam.dev/c/da64c2b6-4a62-4f64-9f6e-752c2613ae7a

Public Sample App

No response

Environment

Release

Severity

High (Blocker to building or releasing)

Issue video log

No response

Version

Self Hosted

@btsgh btsgh added Bug Something isn't working High This issue blocks a user from building or impacts a lot of users Release Needs Triaging Needs attention from maintainers to triage Git Product Issues related to version control product Table Widget V2 Issues related to Table Widget V2 labels Dec 23, 2024
@github-actions github-actions bot added Widgets Product This label groups issues related to widgets Widgets & Accelerators Pod Issues related to widgets & Accelerators Packages & Git Pod All issues belonging to Packages and Git labels Dec 23, 2024
@rahulbarwal
Copy link
Contributor

@btsgh Can you share the app used for testing this? Or share the exported json.

@btsgh
Copy link
Collaborator Author

btsgh commented Dec 24, 2024

I tested this on local, and dont have the app to share. But I have the git connected app details .. which are as below:
This is the repo - https://github.com/btsgh/htmlcolumngittest
This is the git code to connect to the app - git@github.com:btsgh/htmlcolumngittest.git

I have added you to the repo

@rahulbarwal
Copy link
Contributor

rahulbarwal commented Dec 26, 2024

Hey Aparna, I tried by forking your app and then importing it to my local and release, and I was unable to reproduce the behavior shared in your jam video.

Lets talk more when you are back. Attaching videos of what I saw:
Local dev video(latest code)
release.app.appsmith.com video

@btsgh
Copy link
Collaborator Author

btsgh commented Dec 31, 2024

Discussed and showed the behavior to Rahul.

@rahulbarwal
Copy link
Contributor

rahulbarwal commented Dec 31, 2024

Thanks @btsgh .
I debugged this and found out that the problem was a text widget at the bottom of the page.

  • This text widget was bound to {{table.selectedRow.homepage}}, & it was set to auto height.
  • Which meant that when the selected row's link is long, it increased the page size(thus changing the bottom row properties on widgets and pages.

I have removed the text and select widget from the bottom of the page. You should not face this anymore. Let me know if you still are facing any issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Git Product Issues related to version control product High This issue blocks a user from building or impacts a lot of users Needs Triaging Needs attention from maintainers to triage Packages & Git Pod All issues belonging to Packages and Git Release Table Widget V2 Issues related to Table Widget V2 Widgets & Accelerators Pod Issues related to widgets & Accelerators Widgets Product This label groups issues related to widgets
Projects
None yet
Development

No branches or pull requests

2 participants