Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Unable to create any private entity in JS module #32757

Closed
1 task done
subrata71 opened this issue Apr 18, 2024 · 1 comment
Closed
1 task done

[Bug]: Unable to create any private entity in JS module #32757

subrata71 opened this issue Apr 18, 2024 · 1 comment
Assignees
Labels
Bug Something isn't working High This issue blocks a user from building or impacts a lot of users Packages Pod issues that belong to the packages pod Packages Product Issues related to packages Production QA Pod Issues under the QA Pod QA Needs QA attention

Comments

@subrata71
Copy link
Contributor

subrata71 commented Apr 18, 2024

Is there an existing issue for this?

  • I have searched the existing issues

Description

When I try to create any private JS object or query or API inside a JS module, it throws an error as shown in the screenshot

Screenshot 2024-04-18 at 11 25 38 AM

Steps To Reproduce

  1. Create a JS module
  2. Add a query
  3. It will throw an error

Public Sample App

No response

Environment

Production

Severity

Blocker to Building

Issue video log

No response

Version

Self Hosted

@subrata71 subrata71 added Bug Something isn't working Critical This issue needs immediate attention. Drop everything else Needs Triaging Needs attention from maintainers to triage Packages Pod issues that belong to the packages pod labels Apr 18, 2024
@subrata71 subrata71 self-assigned this Apr 18, 2024
@Nikhil-Nandagopal Nikhil-Nandagopal added High This issue blocks a user from building or impacts a lot of users Medium Issues that frustrate users due to poor UX Production and removed Critical This issue needs immediate attention. Drop everything else High This issue blocks a user from building or impacts a lot of users Medium Issues that frustrate users due to poor UX labels Apr 18, 2024
@subrata71
Copy link
Contributor Author

RCA

TL;DR
The issue stemmed from this line.

The purpose of this PR was to enhance control over permissible fields in both request-body and response-body. Fields annotated with @JsonView(FromRequest.class) are deemed permissible in the request body, meaning the deserialization process upon server request considers these fields. Conversely, any field lacking this annotation will be disregarded during deserialization.

In this specific case, the moduleId field was transmitted from the client-side in the request body. However, on the server-side, this field lacked the @JsonView(FromRequest.class) annotation. Consequently, during deserialization, the absence of moduleId led to validation failure.

@appsmith-bot appsmith-bot added the QA Needs QA attention label Apr 18, 2024
@github-actions github-actions bot added the QA Pod Issues under the QA Pod label Apr 18, 2024
@subrata71 subrata71 removed the Needs Triaging Needs attention from maintainers to triage label Apr 18, 2024
@Nikhil-Nandagopal Nikhil-Nandagopal added the Packages Product Issues related to packages label Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working High This issue blocks a user from building or impacts a lot of users Packages Pod issues that belong to the packages pod Packages Product Issues related to packages Production QA Pod Issues under the QA Pod QA Needs QA attention
Projects
None yet
Development

No branches or pull requests

3 participants