Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: Changing the flag to US flag in currency widget's default option #22167

Open
1 task done
Rishabhkaul opened this issue Apr 6, 2023 · 9 comments
Open
1 task done
Assignees
Labels
Currency Input Widget Issues related to currency input widget Enhancement New feature or request Low An issue that is neither critical nor breaks a user flow Widgets & Accelerators Pod Issues related to widgets & Accelerators Widgets Product This label groups issues related to widgets

Comments

@Rishabhkaul
Copy link
Contributor

Rishabhkaul commented Apr 6, 2023

Is there an existing issue for this?

  • I have searched the existing issues

Summary

The default option when using the currency widget is a lesser known flag corresponding to USD. It should probably be US flag. This is on Appsmith cloud.

Screenshot 2023-04-06 at 17 04 02

Why should this be worked on?

US $ is a reasonable default to have in the currency input. However it makes sense to put the US flag there, instead of the current option (I don't know what country that is) since for most cases where people will use US $, they're probably based in USA.

I'd also imagine it might be a relatively minor fix.

@Rishabhkaul Rishabhkaul added the Enhancement New feature or request label Apr 6, 2023
@Nikhil-Nandagopal Nikhil-Nandagopal added the Currency Input Widget Issues related to currency input widget label Apr 8, 2023
@github-actions github-actions bot added the Widgets Product This label groups issues related to widgets label Apr 8, 2023
@Nikhil-Nandagopal
Copy link
Contributor

@Rishabhkaul congrats on opening your first issue :)
@dilippitchika this should be a pretty minor fix right?

@somangshu
Copy link
Contributor

somangshu commented Apr 13, 2023

We have multiple conflict around this, specially the US - types (even comes up with country codes), here is a similar issue #18136

@dilippitchika did document the way forward here
Apparently not a small fix

@dilippitchika
Copy link
Contributor

@somangshu let's kill the country flag in the currency widget, it serves no purpose, the final output is just a currency irrespective of where it's used. Phone is slightly different

@dilippitchika dilippitchika added the Low An issue that is neither critical nor breaks a user flow label Apr 13, 2023
@somangshu
Copy link
Contributor

@dilippitchika can you frame what the final option needs to look like, we will modify our object accordingly!

@somangshu somangshu added the Good First Issue Good for newcomers label Apr 18, 2023
@dilippitchika
Copy link
Contributor

@somangshu https://www.loom.com/share/a50c531a48fb475bab890d7b500148c4

@somangshu
Copy link
Contributor

@dilippitchika makes sense, so for the currency thing we will do currency symbol - currency code > ₹ - INR

While we are thinking about this, Should we also rectify the problem with country code in phone input widget? #18136

@dilippitchika
Copy link
Contributor

We can try it out in phone input but there we need to write the countries because +1 or +2 on it's own is not clear to users. So we have to mention all countries either in short code or full name in the field. But that's a ux issue.

@Vishrut19
Copy link

Hey! Is anyone working on this issue? Or is anyone open to collaborating?

@somangshu
Copy link
Contributor

Thanks for showing interest on the issue @Vishrut19, We would like to manage this issue internally.
Can you please go though other good first issue and see is something is interesting to you

@rohan-arthur rohan-arthur removed the Good First Issue Good for newcomers label Apr 25, 2023
@Nikhil-Nandagopal Nikhil-Nandagopal added the Widgets & Accelerators Pod Issues related to widgets & Accelerators label Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Currency Input Widget Issues related to currency input widget Enhancement New feature or request Low An issue that is neither critical nor breaks a user flow Widgets & Accelerators Pod Issues related to widgets & Accelerators Widgets Product This label groups issues related to widgets
Projects
None yet
Development

No branches or pull requests

7 participants