Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]-[1336]:Decimal operator doesn't work for values that have none zero decimals #21218

Open
1 task done
narhzih opened this issue Mar 7, 2023 · 10 comments
Open
1 task done
Labels
Bug Something isn't working Community Reported issues reported by community members Currency Input Widget Issues related to currency input widget High This issue blocks a user from building or impacts a lot of users Production Widgets & Accelerators Pod Issues related to widgets & Accelerators Widgets Product This label groups issues related to widgets

Comments

@narhzih
Copy link

narhzih commented Mar 7, 2023

Is there an existing issue for this?

  • I have searched the existing issues

Description

When there's a currency input, using values like 100.00 or anything.00 works, but then it's greater than .00 (e.g., .01, .02, or .12), it throws an error saying "Please use. " as the decimal separator for default values."

Steps To Reproduce

  1. Use a currency input
  2. Use a number like 100.15 (non-zero decimal)

Public Sample App

No response

Environment

Production

Issue video log

No response

Version

Cloud & Self - Hosted 1.9.9

@narhzih narhzih added Bug Something isn't working Needs Triaging Needs attention from maintainers to triage labels Mar 7, 2023
@Nikhil-Nandagopal Nikhil-Nandagopal added the Community Reported issues reported by community members label Mar 7, 2023
@dilippitchika
Copy link
Contributor

Few details to note to triage this issue

  1. This happens when the locale/region is brazil where decimals are represented with commas
  2. This should have been fixed in here but it wasn't- [Enhancement]-[84]:Currency widget should allow , to be used as decimal seperator #14261

@dilippitchika dilippitchika added Currency Input Widget Issues related to currency input widget High This issue blocks a user from building or impacts a lot of users labels Mar 7, 2023
@github-actions github-actions bot added the Widgets Product This label groups issues related to widgets label Mar 7, 2023
@somangshu somangshu removed the Needs Triaging Needs attention from maintainers to triage label Mar 15, 2023
@ashit-rath
Copy link
Contributor

Stats

Stat Values
Reach 334
Effort (months) 0.5

@Nikhil-Nandagopal Nikhil-Nandagopal changed the title [Bug]: Decimal operator doesn't work for values that have none zero decimals [Bug]-[1336]:Decimal operator doesn't work for values that have none zero decimals Mar 31, 2023
@Nikhil-Nandagopal Nikhil-Nandagopal changed the title [Bug]: Decimal operator doesn't work for values that have none zero decimals [Bug]-[1336]:Decimal operator doesn't work for values that have none zero decimals Mar 31, 2023
@dilippitchika
Copy link
Contributor

@rajatagrawal can you check this out?

@rajatagrawal
Copy link
Contributor

Hello @narhzih,

Thank you for reaching out to us.

As per the repro steps mentioned by you, we are unable to repro the issue on the latest version of Appsmith. Attaching a loom video that demonstrates the same.

If you think that I have missed something, please let us know. Closing the issue otherwise.

https://www.loom.com/share/1cc6244037c241be92abf3205a888d1c

@rajatagrawal
Copy link
Contributor

Did you mean that localization for default value property in the property pane for currency widget instead ? @narhzih.

Reopening the issue.

@rajatagrawal
Copy link
Contributor

Loom video of issue with default value property field : https://www.loom.com/share/5cf9ab8d07884e2088edb69f4f2ed255

@somangshu
Copy link
Contributor

cc @dilippitchika @rajatagrawal this is still a part of the sprint, are we planning to work on it?

@rajatagrawal
Copy link
Contributor

yes, I will be working on this in this sprint.

@rajatagrawal
Copy link
Contributor

@somangshu

@somangshu somangshu assigned rajatagrawal and unassigned narhzih May 1, 2023
@rajatagrawal
Copy link
Contributor

Had a dicussion with @keyurparalkar and @dilippitchika .

Notes from discussion

We would need to handle cases where the values are stored in DB in . format and would be needed to be converted to ',' format if they are used in the default value validation field if localization is applied.

There are many other similar corner cases that need to be handled for having localization in default column. So, by design the default value only supports '.' as the decimal separator. We assume that a user does not use , as thousands separator because otherwise the value will get parsed as a string.

This issue is not a bug but more of a feature which would be a part of a bigger localization project. Thus, we can work on this issue only if it is a critical.

Moving it out of the sprint for now.

cc : @somangshu

@rajatagrawal rajatagrawal removed their assignment May 5, 2023
@Nikhil-Nandagopal Nikhil-Nandagopal added the Widgets & Accelerators Pod Issues related to widgets & Accelerators label Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Community Reported issues reported by community members Currency Input Widget Issues related to currency input widget High This issue blocks a user from building or impacts a lot of users Production Widgets & Accelerators Pod Issues related to widgets & Accelerators Widgets Product This label groups issues related to widgets
Projects
None yet
Development

No branches or pull requests

8 participants