Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Currency Input widget issues #14835

Open
1 task done
shadabbuchh opened this issue Jun 27, 2022 · 10 comments
Open
1 task done

[Bug]: Currency Input widget issues #14835

shadabbuchh opened this issue Jun 27, 2022 · 10 comments
Assignees
Labels
Bug Something isn't working Currency Input Widget Issues related to currency input widget Low An issue that is neither critical nor breaks a user flow Needs Triaging Needs attention from maintainers to triage Production Widgets & Accelerators Pod Issues related to widgets & Accelerators Widgets Product This label groups issues related to widgets

Comments

@shadabbuchh
Copy link
Contributor

shadabbuchh commented Jun 27, 2022

Is there an existing issue for this?

  • I have searched the existing issues

Description

When user changes the Decimals back to 0, the value does not automatically round off rather the user has to click inside the widget for the value to round off.
https://www.loom.com/share/3257dda3e9b4459a9bf8f49a9bfa280c

Steps To Reproduce

  1. D&D a Currency Input widget.
  2. Set the Decimals to 2.
  3. Enter any value with decimals.
  4. Now change the Decimals value back to 0.

Notice that the value does not automatically round off to the nearest number. The user has to click inside the widget in order to round off the value.

Public Sample App

No response

Version

Cloud

Front logo Front conversations

@shadabbuchh shadabbuchh added Bug Something isn't working Needs Triaging Needs attention from maintainers to triage labels Jun 27, 2022
@github-actions github-actions bot added the potential-duplicate This label marks issues that are potential duplicates of already open issues label Jun 27, 2022
@github-actions
Copy link

We have found issues that are potential duplicates:

  • [[Bug]: Input widget issues #14830] [Bug]: Input widget issues (85%)
    If any of the issues listed above are a duplicate, please consider closing this issue & upvoting the original one.
    Alternatively, if neither of the listed issues addresses your feature/bug, keep this issue open.

@shadabbuchh shadabbuchh added Widgets Product This label groups issues related to widgets Currency Input Widget Issues related to currency input widget Low An issue that is neither critical nor breaks a user flow and removed potential-duplicate This label marks issues that are potential duplicates of already open issues labels Jun 27, 2022
@codedmind
Copy link

Any update on this?

@dilippitchika
Copy link
Contributor

Hey @codedmind this is a low priority item on our plate and I don't think we will get to it anytime soon. Why is this important for you?

@codedmind
Copy link

@dilippitchika one of our apps have a lot of currency widgets and we are not able to input decimals values... so this have a high impact in our end.
Are this difficult to solve? Otherwise we must redo the app and replace the currency widget...

@dilippitchika
Copy link
Contributor

dilippitchika commented Jul 13, 2022

@codedmind this is a different issue, i believe you are talking about this issue - #14261 - where the decimal separator is not working in EU countries as expected.

This current issue is a different issue, which only happens in the edit mode and has no impact on view mode

@codedmind
Copy link

@dilippitchika your are correct! My mistake ... any news regarding that issue :D

@dilippitchika
Copy link
Contributor

We have figured out a solution, but are stuck in terms of scaling that. Could you help us with the details of how your users use currencies, do all of them follow a single style for entering decimals like . or based on the country they are located in they change the way they write decimals?

@codedmind
Copy link

@dilippitchika yes they all use the same way... in our case the decimal is the comma

@prasad-madine
Copy link
Contributor

Hi @shadabbuchh , I'm picking this issue.

@prasad-madine
Copy link
Contributor

prasad-madine commented Jul 12, 2024

Hi @shadabbuchh , the selected decimals are not being reflected even on clicking inside the widget, as contrary to the description mentioned. I have implemented reflecting decimal values when clicking inside the widget i.e., onFocus, or the value should be reflected when the decimals changed.
Share your input over hear.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Currency Input Widget Issues related to currency input widget Low An issue that is neither critical nor breaks a user flow Needs Triaging Needs attention from maintainers to triage Production Widgets & Accelerators Pod Issues related to widgets & Accelerators Widgets Product This label groups issues related to widgets
Projects
None yet
Development

No branches or pull requests

6 participants