Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: The hide and unhide functionality are swapped by hiding a column and pressing cmd+z for redo #10177

Closed
1 task done
YogeshJayaseelan opened this issue Jan 5, 2022 · 2 comments
Assignees
Labels
Bug Something isn't working Low An issue that is neither critical nor breaks a user flow Production UI Building Product Issues related to the UI Building experience Undo/Redo Issues related to undo/redo

Comments

@YogeshJayaseelan
Copy link
Contributor

YogeshJayaseelan commented Jan 5, 2022

Is there an existing issue for this?

  • I have searched the existing issues

Current Behavior

It is observed that by hiding any columns in the table property pane and by pressing cmd+z the hided column will be re-displayed but the unhide icon will be displayed in the property pane and which is turn pressing the unhide icon will agaon hie the column

LOOM DEMO

Steps To Reproduce

1.Launch appsmith app in release/Production environment
2.Drag and drop table widget
3.Open property pane
4.Hide any of the column by clicking on hide icon
5.Press cmd+z for redo and check the column will be displayed in the table widget but still in the property pane hide icon will be displayed

Environment

Production

Version

Cloud

@YogeshJayaseelan YogeshJayaseelan added Bug Something isn't working Table Widget Low An issue that is neither critical nor breaks a user flow Production Needs Triaging Needs attention from maintainers to triage labels Jan 5, 2022
@github-actions github-actions bot added Widgets Product This label groups issues related to widgets UI Building Pod labels Jan 5, 2022
@somangshu somangshu added Undo/Redo Issues related to undo/redo and removed Needs Triaging Needs attention from maintainers to triage labels Jan 5, 2022
@github-actions github-actions bot added the UI Building Product Issues related to the UI Building experience label Jan 5, 2022
@somangshu
Copy link
Contributor

This is more of a re-rendering issue when it comes to undo/redo, Opening the same property pane again shows the correct changes

cc @jsartisan @marks0351

@somangshu somangshu removed Table Widget Widgets Product This label groups issues related to widgets labels Jan 5, 2022
@somangshu somangshu assigned prsidhu and unassigned riodeuno, jsartisan and marks0351 Feb 21, 2022
@riodeuno
Copy link
Contributor

riodeuno commented Mar 7, 2022

@prsidhu @sbalaji1192 This seems to be a standard data integrity issue, where there are multiple sources for the truth about the hidden columns. We should update the code, so that this property is taken from on source which should ideally be the primaryColumns configuration for the column in question.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Low An issue that is neither critical nor breaks a user flow Production UI Building Product Issues related to the UI Building experience Undo/Redo Issues related to undo/redo
Projects
None yet
Development

No branches or pull requests

7 participants