From 6ab9684b737290ebc2476ca959477246d1b3766b Mon Sep 17 00:00:00 2001 From: Ayush Pahwa Date: Thu, 19 Sep 2024 11:54:04 +0800 Subject: [PATCH 1/6] feat: telemetry added for current linter (#36400) --- .../src/plugins/Linting/utils/getLintingErrors.ts | 15 +++++++++++++-- 1 file changed, 13 insertions(+), 2 deletions(-) diff --git a/app/client/src/plugins/Linting/utils/getLintingErrors.ts b/app/client/src/plugins/Linting/utils/getLintingErrors.ts index 74b0b60ea62..2a681a875c4 100644 --- a/app/client/src/plugins/Linting/utils/getLintingErrors.ts +++ b/app/client/src/plugins/Linting/utils/getLintingErrors.ts @@ -36,6 +36,8 @@ import setters from "workers/Evaluation/setters"; import { isMemberExpressionNode } from "@shared/ast/src"; import { generate } from "astring"; import getInvalidModuleInputsError from "ee/plugins/Linting/utils/getInvalidModuleInputsError"; +import { startAndEndSpanForFn } from "UITelemetry/generateTraces"; +import { objectKeys } from "@appsmith/utils"; const EvaluationScriptPositions: Record = {}; @@ -67,7 +69,7 @@ function generateLintingGlobalData(data: Record) { libAccessors.forEach((accessor) => (globalData[accessor] = true)); // Add all supported web apis - Object.keys(SUPPORTED_WEB_APIS).forEach( + objectKeys(SUPPORTED_WEB_APIS).forEach( (apiName) => (globalData[apiName] = true), ); @@ -195,7 +197,16 @@ export default function getLintingErrors({ const lintingGlobalData = generateLintingGlobalData(data); const lintingOptions = lintOptions(lintingGlobalData); - jshint(script, lintingOptions); + startAndEndSpanForFn( + "Linter", + // adding some metrics to compare the performance changes with eslint + { + linter: "JSHint", + linesOfCodeLinted: originalBinding.split("\n").length, + codeSizeInChars: originalBinding.length, + }, + () => jshint(script, lintingOptions), + ); const sanitizedJSHintErrors = sanitizeJSHintErrors(jshint.errors, scriptPos); const jshintErrors: LintError[] = sanitizedJSHintErrors.map((lintError) => convertJsHintErrorToAppsmithLintError( From c2521fae8101ab757cc9e9fcbe3300de423325f2 Mon Sep 17 00:00:00 2001 From: Diljit Date: Thu, 19 Sep 2024 11:06:14 +0530 Subject: [PATCH 2/6] chore: Page load instrumentation: add network and device info to page load spans (#36395) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit ## Description - Remove page visibility change listener in Page load instrumentation. The page visibility data is not working as expected. - Add `otlpSessionId` and `appMode` attributes to all PageView and PageViewTimings data pushed by the new relic browser agent. This will help us infer session based information and join reports with Page load Spans - Add network and device specific attributes to the `PAGE_LOAD` span Fixes #`Issue Number` _or_ Fixes `Issue URL` > [!WARNING] > _If no issue exists, please create an issue first, and check with the maintainers if the issue is valid._ ## Automation /ok-to-test tags="@tag.Sanity" ### :mag: Cypress test results > [!TIP] > 🟒 🟒 🟒 All cypress tests have passed! πŸŽ‰ πŸŽ‰ πŸŽ‰ > Workflow run: > Commit: de172593ce8d7782fb526d3294e8a63155e3c849 > Cypress dashboard. > Tags: `@tag.Sanity` > Spec: >
Thu, 19 Sep 2024 05:22:19 UTC ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [ ] No ## Summary by CodeRabbit - **New Features** - Enhanced telemetry data collection during page load events, capturing device memory and network attributes. - Introduced functionality to gather operating system details (name and version) for improved telemetry insights. - Improved integration with New Relic for detailed monitoring through custom attributes. - **Bug Fixes** - Removed outdated logic for tracking page visibility, focusing on more relevant metrics. --- .../UITelemetry/PageLoadInstrumentation.ts | 50 +++++++++++++------ app/client/src/UITelemetry/generateTraces.ts | 12 ++++- app/client/src/index.tsx | 8 ++- 3 files changed, 51 insertions(+), 19 deletions(-) diff --git a/app/client/src/UITelemetry/PageLoadInstrumentation.ts b/app/client/src/UITelemetry/PageLoadInstrumentation.ts index b297163d146..ccb173d0b4a 100644 --- a/app/client/src/UITelemetry/PageLoadInstrumentation.ts +++ b/app/client/src/UITelemetry/PageLoadInstrumentation.ts @@ -9,6 +9,16 @@ import type { } from "web-vitals"; import isString from "lodash/isString"; +type TNavigator = Navigator & { + deviceMemory: number; + connection: { + effectiveType: string; + downlink: number; + rtt: number; + saveData: boolean; + }; +}; + export class PageLoadInstrumentation extends InstrumentationBase { // PerformanceObserver to observe resource timings resourceTimingObserver: PerformanceObserver | null = null; @@ -16,10 +26,6 @@ export class PageLoadInstrumentation extends InstrumentationBase { rootSpan: Span; // List of resource URLs to ignore ignoreResourceUrls: string[] = []; - // Timestamp when the page was last hidden - pageLastHiddenAt: number = 0; - // Duration the page was hidden for - pageHiddenFor: number = 0; // Flag to check if navigation entry was pushed wasNavigationEntryPushed: boolean = false; // Set to keep track of resource entries @@ -44,7 +50,11 @@ export class PageLoadInstrumentation extends InstrumentationBase { } enable(): void { - this.addVisibilityChangeListener(); + // Register connection change listener + this.addConnectionAttributes(); + + // Add device attributes to the root span + this.addDeviceAttributes(); // Listen for LCP and FCP events // reportAllChanges: true will report all LCP and FCP events @@ -61,19 +71,28 @@ export class PageLoadInstrumentation extends InstrumentationBase { } } - private addVisibilityChangeListener() { - // Listen for page visibility changes to track time spent on hidden page - document.addEventListener("visibilitychange", () => { - if (document.visibilityState === "hidden") { - this.pageLastHiddenAt = performance.now(); - } else { - const endTime = performance.now(); - - this.pageHiddenFor = endTime - this.pageLastHiddenAt; - } + private addDeviceAttributes() { + this.rootSpan.setAttributes({ + deviceMemory: (navigator as TNavigator).deviceMemory, + hardwareConcurrency: navigator.hardwareConcurrency, }); } + private addConnectionAttributes() { + if ((navigator as TNavigator).connection) { + const { downlink, effectiveType, rtt, saveData } = ( + navigator as TNavigator + ).connection; + + this.rootSpan.setAttributes({ + effectiveConnectionType: effectiveType, + connectionDownlink: downlink, + connectionRtt: rtt, + connectionSaveData: saveData, + }); + } + } + // Handler for LCP report private onLCPReport(metric: LCPMetricWithAttribution) { const { @@ -156,7 +175,6 @@ export class PageLoadInstrumentation extends InstrumentationBase { element: this.getElementName(element), entryType, loadTime, - pageHiddenFor: this.pageHiddenFor, }, 0, ); diff --git a/app/client/src/UITelemetry/generateTraces.ts b/app/client/src/UITelemetry/generateTraces.ts index d3860933f17..12476bcbcfa 100644 --- a/app/client/src/UITelemetry/generateTraces.ts +++ b/app/client/src/UITelemetry/generateTraces.ts @@ -7,7 +7,13 @@ import type { import { SpanKind } from "@opentelemetry/api"; import { context } from "@opentelemetry/api"; import { trace } from "@opentelemetry/api"; -import { deviceType, browserName, browserVersion } from "react-device-detect"; +import { + deviceType, + browserName, + browserVersion, + osName, + osVersion, +} from "react-device-detect"; import { APP_MODE } from "entities/App"; import { matchBuilderPath, matchViewerPath } from "constants/routes"; import nanoid from "nanoid"; @@ -33,7 +39,7 @@ const getAppMode = memoizeOne((pathname: string) => { return appMode; }); -const getCommonTelemetryAttributes = () => { +export const getCommonTelemetryAttributes = () => { const pathname = window.location.pathname; const appMode = getAppMode(pathname); @@ -44,6 +50,8 @@ const getCommonTelemetryAttributes = () => { browserVersion, otlpSessionId: OTLP_SESSION_ID, hostname: window.location.hostname, + osName, + osVersion, }; }; diff --git a/app/client/src/index.tsx b/app/client/src/index.tsx index 2a950f2c8d5..c5c6db423d3 100755 --- a/app/client/src/index.tsx +++ b/app/client/src/index.tsx @@ -29,6 +29,7 @@ import { getAppsmithConfigs } from "ee/configs"; import { PageViewTiming } from "@newrelic/browser-agent/features/page_view_timing"; import { PageViewEvent } from "@newrelic/browser-agent/features/page_view_event"; import { Agent } from "@newrelic/browser-agent/loaders/agent"; +import { getCommonTelemetryAttributes } from "UITelemetry/generateTraces"; const { newRelic } = getAppsmithConfigs(); const { enableNewRelic } = newRelic; @@ -56,7 +57,7 @@ const newRelicBrowserAgentConfig = { // The agent loader code executes immediately on instantiation. if (enableNewRelic) { - new Agent( + const newRelicBrowserAgent = new Agent( { ...newRelicBrowserAgentConfig, features: [PageViewTiming, PageViewEvent], @@ -65,6 +66,11 @@ if (enableNewRelic) { // Passing a null value throws an error as well. So we pass undefined. undefined, ); + + const { appMode, otlpSessionId } = getCommonTelemetryAttributes(); + + newRelicBrowserAgent.setCustomAttribute("otlpSessionId", otlpSessionId); + newRelicBrowserAgent.setCustomAttribute("appMode", appMode); } const shouldAutoFreeze = process.env.NODE_ENV === "development"; From 006dbfd46a2843dec41db186dbc0c45e7b755d4a Mon Sep 17 00:00:00 2001 From: NandanAnantharamu <67676905+NandanAnantharamu@users.noreply.github.com> Date: Thu, 19 Sep 2024 11:39:44 +0530 Subject: [PATCH 3/6] test:Fix canvas context prop01 (#36391) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit EE PR: https://github.com/appsmithorg/appsmith-ee/pull/5159 RCA: The property section related validations were not working Solution: Enhanced verification of property pane section visibility using accessibility attributes. Introduced new UI interaction properties for managing collapsible sections. /ok-to-test tags="@tag.IDE" > [!TIP] > 🟒 🟒 🟒 All cypress tests have passed! πŸŽ‰ πŸŽ‰ πŸŽ‰ > Workflow run: > Commit: c996a38fba4d94cf80baf574d6ad3db75b2bb8cf > Cypress dashboard. > Tags: `@tag.IDE` > Spec: >
Wed, 18 Sep 2024 14:10:07 UTC ## Summary by CodeRabbit - **New Features** - Improved test logic for verifying the state of property pane sections, enhancing accessibility compliance. - Updated limited tests to include new test specifications for the property pane. - **Bug Fixes** - Enhanced robustness of tests by refining visibility state checks using ARIA attributes. - **Chores** - Expanded locator capabilities in the testing framework to support new UI components related to collapsible sections. --------- Co-authored-by: β€œNandanAnantharamu” <β€œnandan@thinkify.io”> --- .../IDE/Canvas_Context_Property_Pane_1_spec.js | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/app/client/cypress/e2e/Regression/ClientSide/IDE/Canvas_Context_Property_Pane_1_spec.js b/app/client/cypress/e2e/Regression/ClientSide/IDE/Canvas_Context_Property_Pane_1_spec.js index 9b4fca2e6bc..0913adcfa78 100644 --- a/app/client/cypress/e2e/Regression/ClientSide/IDE/Canvas_Context_Property_Pane_1_spec.js +++ b/app/client/cypress/e2e/Regression/ClientSide/IDE/Canvas_Context_Property_Pane_1_spec.js @@ -211,12 +211,14 @@ function verifyPropertyPaneSectionState(propertySectionState) { for (const [sectionName, shouldSectionOpen] of Object.entries( propertySectionState, )) { - cy.get("body").then(($body) => { - const isSectionOpen = - $body.find(`${propertySectionClass(sectionName)} .t--chevron-icon`) - .length > 0; - expect(isSectionOpen).to.equal(shouldSectionOpen); - }); + cy.get(`${propertySectionClass(sectionName)}`) + .siblings(_.locators._propertyCollapse) + .find(_.locators._propertyCollapseBody) + .invoke("attr", "aria-hidden") + .then((isSectionOpen) => { + const expectedValue = shouldSectionOpen ? "false" : "true"; // Convert boolean to aria-hidden value + expect(isSectionOpen).to.equal(expectedValue); + }); } } From aa18a4f46de6a01c281b7f487f43c6db23372e75 Mon Sep 17 00:00:00 2001 From: Rahul Barwal Date: Thu, 19 Sep 2024 13:49:52 +0530 Subject: [PATCH 4/6] chore: Removes unused feature flag ref (#36416) --- .../PartialImportExport/PartialExportModal/unitTestUtils.ts | 1 - 1 file changed, 1 deletion(-) diff --git a/app/client/src/components/editorComponents/PartialImportExport/PartialExportModal/unitTestUtils.ts b/app/client/src/components/editorComponents/PartialImportExport/PartialExportModal/unitTestUtils.ts index d066f825510..d75f566697a 100644 --- a/app/client/src/components/editorComponents/PartialImportExport/PartialExportModal/unitTestUtils.ts +++ b/app/client/src/components/editorComponents/PartialImportExport/PartialExportModal/unitTestUtils.ts @@ -12780,7 +12780,6 @@ export const defaultAppState = { ab_ds_binding_enabled: true, ask_ai_js: false, license_connection_pool_size_enabled: false, - release_widgetdiscovery_enabled: false, ab_ai_js_function_completion_enabled: true, release_workflows_enabled: false, license_scim_enabled: false, From 163bde4027cb2b2812178724b03a10f3464604c4 Mon Sep 17 00:00:00 2001 From: Ayush Pahwa Date: Thu, 19 Sep 2024 16:20:24 +0800 Subject: [PATCH 5/6] chore: Revert "feat: telemetry added for current linter (#36400)" (#36411) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit This reverts commit 6ab9684b737290ebc2476ca959477246d1b3766b. ## Description PR to revert changes made in telemetry for linter Fixes #`Issue Number` _or_ Fixes `Issue URL` > [!WARNING] > _If no issue exists, please create an issue first, and check with the maintainers if the issue is valid._ ## Automation /test js ### :mag: Cypress test results > [!TIP] > 🟒 🟒 🟒 All cypress tests have passed! πŸŽ‰ πŸŽ‰ πŸŽ‰ > Workflow run: > Commit: 00ef3209fe35ed23db8aa7df0958f95359eb1363 > Cypress dashboard. > Tags: `@tag.JS` > Spec: >
Thu, 19 Sep 2024 07:56:21 UTC ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [x] No ## Summary by CodeRabbit - **New Features** - Simplified linting process by removing telemetry-related functionality. - **Bug Fixes** - Improved performance and maintainability of the linting process. - **Refactor** - Updated method for retrieving keys from an object to use standard JavaScript functionality. --- .../src/plugins/Linting/utils/getLintingErrors.ts | 15 ++------------- 1 file changed, 2 insertions(+), 13 deletions(-) diff --git a/app/client/src/plugins/Linting/utils/getLintingErrors.ts b/app/client/src/plugins/Linting/utils/getLintingErrors.ts index 2a681a875c4..74b0b60ea62 100644 --- a/app/client/src/plugins/Linting/utils/getLintingErrors.ts +++ b/app/client/src/plugins/Linting/utils/getLintingErrors.ts @@ -36,8 +36,6 @@ import setters from "workers/Evaluation/setters"; import { isMemberExpressionNode } from "@shared/ast/src"; import { generate } from "astring"; import getInvalidModuleInputsError from "ee/plugins/Linting/utils/getInvalidModuleInputsError"; -import { startAndEndSpanForFn } from "UITelemetry/generateTraces"; -import { objectKeys } from "@appsmith/utils"; const EvaluationScriptPositions: Record = {}; @@ -69,7 +67,7 @@ function generateLintingGlobalData(data: Record) { libAccessors.forEach((accessor) => (globalData[accessor] = true)); // Add all supported web apis - objectKeys(SUPPORTED_WEB_APIS).forEach( + Object.keys(SUPPORTED_WEB_APIS).forEach( (apiName) => (globalData[apiName] = true), ); @@ -197,16 +195,7 @@ export default function getLintingErrors({ const lintingGlobalData = generateLintingGlobalData(data); const lintingOptions = lintOptions(lintingGlobalData); - startAndEndSpanForFn( - "Linter", - // adding some metrics to compare the performance changes with eslint - { - linter: "JSHint", - linesOfCodeLinted: originalBinding.split("\n").length, - codeSizeInChars: originalBinding.length, - }, - () => jshint(script, lintingOptions), - ); + jshint(script, lintingOptions); const sanitizedJSHintErrors = sanitizeJSHintErrors(jshint.errors, scriptPos); const jshintErrors: LintError[] = sanitizedJSHintErrors.map((lintError) => convertJsHintErrorToAppsmithLintError( From bb0ec5ce9d5c9cb92e4fbea6e0c4b5693cde2743 Mon Sep 17 00:00:00 2001 From: Valera Melnikov Date: Thu, 19 Sep 2024 14:22:21 +0300 Subject: [PATCH 6/6] fix: disable anvil snapshots tests (#36422) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit ## Description Disable all Anvil snapshot tests. The tests will be enabled after solving the #36419. Related thread https://theappsmith.slack.com/archives/C025SE88KNE/p1726721979435589 ## Automation /ok-to-test tags="@tag.All" ### :mag: Cypress test results > [!TIP] > 🟒 🟒 🟒 All cypress tests have passed! πŸŽ‰ πŸŽ‰ πŸŽ‰ > Workflow run: > Commit: ee5c8f40eb3873bd9db8d9b7ca4c3519d989a038 > Cypress dashboard. > Tags: `@tag.All` > Spec: >
Thu, 19 Sep 2024 11:14:18 UTC ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [x] No ## Summary by CodeRabbit - **Bug Fixes** - Temporarily skipped multiple test suites for various Anvil widgets due to unresolved issues, preventing potential false negatives in testing. - Specific tests affected include those for Modal sizes, App Theming, Button, Checkbox, Currency Input, Heading, Icon Button, Inline Button, Input, Paragraph, Phone Input, Radio Group, Stats, Switch Group, Switch, Table, Toolbar Button, and Zone Section Widgets. These adjustments ensure the integrity of the testing process while issues are being addressed. --- .../e2e/Regression/ClientSide/Anvil/AnvilModal_spec.ts | 3 ++- .../Anvil/AppTheming/AnvilAppThemingSnapshot_spec.ts | 3 ++- .../Anvil/Widgets/AnvilButtonWidgetSnapshot_spec.ts | 3 ++- .../Anvil/Widgets/AnvilCheckboxGroupWidgetSnapshot_spec.ts | 3 ++- .../Anvil/Widgets/AnvilCheckboxWidgetSnapshot_spec.ts | 3 ++- .../Anvil/Widgets/AnvilCurrencyInputWidgetSnapshot_spec.ts | 3 ++- .../Anvil/Widgets/AnvilHeadingWidgetSnapshot_spec.ts | 3 ++- .../Anvil/Widgets/AnvilIconButtonWidgetSnapshot_spec.ts | 3 ++- .../Anvil/Widgets/AnvilInlineButtonWidgetSnapshot_spec.ts | 3 ++- .../Anvil/Widgets/AnvilInputWidgetSnapshot_spec.ts | 3 ++- .../Anvil/Widgets/AnvilParagraphWidgetSnapshot_spec.ts | 3 ++- .../Anvil/Widgets/AnvilPhoneInputWidgetSnapshot_spec.ts | 3 ++- .../Anvil/Widgets/AnvilRadioGroupWidgetSnapshot_spec.ts | 3 ++- .../Anvil/Widgets/AnvilStatsWidgetSnapshot_spec.ts | 5 +++-- .../Anvil/Widgets/AnvilSwitchGroupWidgetSnapshot_spec.ts | 3 ++- .../Anvil/Widgets/AnvilSwitchWidgetSnapshot_spec.ts | 3 ++- .../Anvil/Widgets/AnvilTableWidgetSnapshot_spec.ts | 3 ++- .../Anvil/Widgets/AnvilToolbarButtonWidgetSnapshot_spec.ts | 3 ++- .../Anvil/Widgets/AnvilZoneSectionWidgetSnapshot_spec.ts | 3 ++- 19 files changed, 39 insertions(+), 20 deletions(-) diff --git a/app/client/cypress/e2e/Regression/ClientSide/Anvil/AnvilModal_spec.ts b/app/client/cypress/e2e/Regression/ClientSide/Anvil/AnvilModal_spec.ts index c253987eb48..84b5d5e3b91 100644 --- a/app/client/cypress/e2e/Regression/ClientSide/Anvil/AnvilModal_spec.ts +++ b/app/client/cypress/e2e/Regression/ClientSide/Anvil/AnvilModal_spec.ts @@ -134,7 +134,8 @@ describe( anvilLocators.anvilWidgetNameSelector("Button2"), ); }); - it("8. Verify different modal sizes", () => { + // TODO: Enable when issue(github.com/appsmithorg/appsmith/issues/36419) is solved. + it.skip("8. Verify different modal sizes", () => { // select all widgets and delete agHelper.PressEscape(); agHelper.SelectAllWidgets(); diff --git a/app/client/cypress/e2e/Regression/ClientSide/Anvil/AppTheming/AnvilAppThemingSnapshot_spec.ts b/app/client/cypress/e2e/Regression/ClientSide/Anvil/AppTheming/AnvilAppThemingSnapshot_spec.ts index 6f2bb3ff6e6..5b9bad823b3 100644 --- a/app/client/cypress/e2e/Regression/ClientSide/Anvil/AppTheming/AnvilAppThemingSnapshot_spec.ts +++ b/app/client/cypress/e2e/Regression/ClientSide/Anvil/AppTheming/AnvilAppThemingSnapshot_spec.ts @@ -4,7 +4,8 @@ import { anvilSnapshot, } from "../../../../../support/Objects/ObjectsCore"; -describe( +// TODO: Enable when issue(github.com/appsmithorg/appsmith/issues/36419) is solved. +describe.skip( `${ANVIL_EDITOR_TEST}: Anvil tests for App Theming`, { tags: ["@tag.Anvil"] }, () => { diff --git a/app/client/cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilButtonWidgetSnapshot_spec.ts b/app/client/cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilButtonWidgetSnapshot_spec.ts index 210fdf47b57..a78e7ef5d47 100644 --- a/app/client/cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilButtonWidgetSnapshot_spec.ts +++ b/app/client/cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilButtonWidgetSnapshot_spec.ts @@ -4,7 +4,8 @@ import { anvilSnapshot, } from "../../../../../support/Objects/ObjectsCore"; -describe( +// TODO: Enable when issue(github.com/appsmithorg/appsmith/issues/36419) is solved. +describe.skip( `${ANVIL_EDITOR_TEST}: Anvil tests for Button Widget`, { tags: ["@tag.Anvil", "@tag.Visual"] }, () => { diff --git a/app/client/cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilCheckboxGroupWidgetSnapshot_spec.ts b/app/client/cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilCheckboxGroupWidgetSnapshot_spec.ts index 98e24b1e0b2..66b66d583e7 100644 --- a/app/client/cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilCheckboxGroupWidgetSnapshot_spec.ts +++ b/app/client/cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilCheckboxGroupWidgetSnapshot_spec.ts @@ -4,7 +4,8 @@ import { anvilSnapshot, } from "../../../../../support/Objects/ObjectsCore"; -describe( +// TODO: Enable when issue(github.com/appsmithorg/appsmith/issues/36419) is solved. +describe.skip( `${ANVIL_EDITOR_TEST}: Anvil tests for Checkbox Group Widget`, { tags: ["@tag.Anvil", "@tag.Visual"] }, () => { diff --git a/app/client/cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilCheckboxWidgetSnapshot_spec.ts b/app/client/cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilCheckboxWidgetSnapshot_spec.ts index 3cd3bd49848..5ad568bf5a2 100644 --- a/app/client/cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilCheckboxWidgetSnapshot_spec.ts +++ b/app/client/cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilCheckboxWidgetSnapshot_spec.ts @@ -4,7 +4,8 @@ import { anvilSnapshot, } from "../../../../../support/Objects/ObjectsCore"; -describe( +// TODO: Enable when issue(github.com/appsmithorg/appsmith/issues/36419) is solved. +describe.skip( `${ANVIL_EDITOR_TEST}: Anvil tests for Checkbox Widget`, { tags: ["@tag.Anvil", "@tag.Visual"] }, () => { diff --git a/app/client/cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilCurrencyInputWidgetSnapshot_spec.ts b/app/client/cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilCurrencyInputWidgetSnapshot_spec.ts index 3e41473ebfe..5300cb6c565 100644 --- a/app/client/cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilCurrencyInputWidgetSnapshot_spec.ts +++ b/app/client/cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilCurrencyInputWidgetSnapshot_spec.ts @@ -4,7 +4,8 @@ import { anvilSnapshot, } from "../../../../../support/Objects/ObjectsCore"; -describe( +// TODO: Enable when issue(github.com/appsmithorg/appsmith/issues/36419) is solved. +describe.skip( `${ANVIL_EDITOR_TEST}: Anvil tests for Currency Input Widget`, { tags: ["@tag.Anvil", "@tag.Visual"] }, () => { diff --git a/app/client/cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilHeadingWidgetSnapshot_spec.ts b/app/client/cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilHeadingWidgetSnapshot_spec.ts index 89991dabaf3..82ae69d9a07 100644 --- a/app/client/cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilHeadingWidgetSnapshot_spec.ts +++ b/app/client/cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilHeadingWidgetSnapshot_spec.ts @@ -4,7 +4,8 @@ import { anvilSnapshot, } from "../../../../../support/Objects/ObjectsCore"; -describe( +// TODO: Enable when issue(github.com/appsmithorg/appsmith/issues/36419) is solved. +describe.skip( `${ANVIL_EDITOR_TEST}: Anvil tests for Heading Widget`, { tags: ["@tag.Anvil", "@tag.Visual"] }, () => { diff --git a/app/client/cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilIconButtonWidgetSnapshot_spec.ts b/app/client/cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilIconButtonWidgetSnapshot_spec.ts index b73f2486036..5adb9bde936 100644 --- a/app/client/cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilIconButtonWidgetSnapshot_spec.ts +++ b/app/client/cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilIconButtonWidgetSnapshot_spec.ts @@ -4,7 +4,8 @@ import { anvilSnapshot, } from "../../../../../support/Objects/ObjectsCore"; -describe( +// TODO: Enable when issue(github.com/appsmithorg/appsmith/issues/36419) is solved. +describe.skip( `${ANVIL_EDITOR_TEST}: Anvil tests for Icon Button Widget`, { tags: ["@tag.Anvil", "@tag.Visual"] }, () => { diff --git a/app/client/cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilInlineButtonWidgetSnapshot_spec.ts b/app/client/cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilInlineButtonWidgetSnapshot_spec.ts index a75a3048216..9899b8ce2f7 100644 --- a/app/client/cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilInlineButtonWidgetSnapshot_spec.ts +++ b/app/client/cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilInlineButtonWidgetSnapshot_spec.ts @@ -4,7 +4,8 @@ import { anvilSnapshot, } from "../../../../../support/Objects/ObjectsCore"; -describe( +// TODO: Enable when issue(github.com/appsmithorg/appsmith/issues/36419) is solved. +describe.skip( `${ANVIL_EDITOR_TEST}: Anvil tests for Inline Button Widget`, { tags: ["@tag.Anvil", "@tag.Visual"] }, () => { diff --git a/app/client/cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilInputWidgetSnapshot_spec.ts b/app/client/cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilInputWidgetSnapshot_spec.ts index 0ed3244be5c..5751a4d3a86 100644 --- a/app/client/cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilInputWidgetSnapshot_spec.ts +++ b/app/client/cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilInputWidgetSnapshot_spec.ts @@ -4,7 +4,8 @@ import { anvilSnapshot, } from "../../../../../support/Objects/ObjectsCore"; -describe( +// TODO: Enable when issue(github.com/appsmithorg/appsmith/issues/36419) is solved. +describe.skip( `${ANVIL_EDITOR_TEST}: Anvil tests for Input Widget`, { tags: ["@tag.Anvil", "@tag.Visual"] }, () => { diff --git a/app/client/cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilParagraphWidgetSnapshot_spec.ts b/app/client/cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilParagraphWidgetSnapshot_spec.ts index 009f63dad63..eac9c2178ef 100644 --- a/app/client/cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilParagraphWidgetSnapshot_spec.ts +++ b/app/client/cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilParagraphWidgetSnapshot_spec.ts @@ -4,7 +4,8 @@ import { anvilSnapshot, } from "../../../../../support/Objects/ObjectsCore"; -describe( +// TODO: Enable when issue(github.com/appsmithorg/appsmith/issues/36419) is solved. +describe.skip( `${ANVIL_EDITOR_TEST}: Anvil tests for Paragraph Widget`, { tags: ["@tag.Anvil", "@tag.Visual"] }, () => { diff --git a/app/client/cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilPhoneInputWidgetSnapshot_spec.ts b/app/client/cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilPhoneInputWidgetSnapshot_spec.ts index 653df4d7871..634a4154f84 100644 --- a/app/client/cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilPhoneInputWidgetSnapshot_spec.ts +++ b/app/client/cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilPhoneInputWidgetSnapshot_spec.ts @@ -4,7 +4,8 @@ import { anvilSnapshot, } from "../../../../../support/Objects/ObjectsCore"; -describe( +// TODO: Enable when issue(github.com/appsmithorg/appsmith/issues/36419) is solved. +describe.skip( `${ANVIL_EDITOR_TEST}: Anvil tests for Phone Input Widget`, { tags: ["@tag.Anvil", "@tag.Visual"] }, () => { diff --git a/app/client/cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilRadioGroupWidgetSnapshot_spec.ts b/app/client/cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilRadioGroupWidgetSnapshot_spec.ts index dfa3d796373..7b90dbce28a 100644 --- a/app/client/cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilRadioGroupWidgetSnapshot_spec.ts +++ b/app/client/cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilRadioGroupWidgetSnapshot_spec.ts @@ -4,7 +4,8 @@ import { anvilSnapshot, } from "../../../../../support/Objects/ObjectsCore"; -describe( +// TODO: Enable when issue(github.com/appsmithorg/appsmith/issues/36419) is solved. +describe.skip( `${ANVIL_EDITOR_TEST}: Anvil tests for Radio Group Widget`, { tags: ["@tag.Anvil", "@tag.Visual"] }, () => { diff --git a/app/client/cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilStatsWidgetSnapshot_spec.ts b/app/client/cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilStatsWidgetSnapshot_spec.ts index 87af914cbde..51da8ac2395 100644 --- a/app/client/cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilStatsWidgetSnapshot_spec.ts +++ b/app/client/cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilStatsWidgetSnapshot_spec.ts @@ -4,7 +4,8 @@ import { anvilSnapshot, } from "../../../../../support/Objects/ObjectsCore"; -describe( +// TODO: Enable when issue(github.com/appsmithorg/appsmith/issues/36419) is solved. +describe.skip( `${ANVIL_EDITOR_TEST}: Anvil tests for Stats Widget`, { tags: ["@tag.Anvil", "@tag.Visual"] }, () => { @@ -20,7 +21,7 @@ describe( }); it("2. Preview Mode", () => { - anvilSnapshot.enterPreviewMode("StatsWidget"); + anvilSnapshot.enterPreviewMode(); }); it("3. Deploy Mode", () => { diff --git a/app/client/cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilSwitchGroupWidgetSnapshot_spec.ts b/app/client/cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilSwitchGroupWidgetSnapshot_spec.ts index 8e183efadc0..2ffed43ba43 100644 --- a/app/client/cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilSwitchGroupWidgetSnapshot_spec.ts +++ b/app/client/cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilSwitchGroupWidgetSnapshot_spec.ts @@ -4,7 +4,8 @@ import { anvilSnapshot, } from "../../../../../support/Objects/ObjectsCore"; -describe( +// TODO: Enable when issue(github.com/appsmithorg/appsmith/issues/36419) is solved. +describe.skip( `${ANVIL_EDITOR_TEST}: Anvil tests for Switch Group Widget`, { tags: ["@tag.Anvil", "@tag.Visual"] }, () => { diff --git a/app/client/cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilSwitchWidgetSnapshot_spec.ts b/app/client/cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilSwitchWidgetSnapshot_spec.ts index c8bdf612496..aec145739a2 100644 --- a/app/client/cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilSwitchWidgetSnapshot_spec.ts +++ b/app/client/cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilSwitchWidgetSnapshot_spec.ts @@ -4,7 +4,8 @@ import { anvilSnapshot, } from "../../../../../support/Objects/ObjectsCore"; -describe( +// TODO: Enable when issue(github.com/appsmithorg/appsmith/issues/36419) is solved. +describe.skip( `${ANVIL_EDITOR_TEST}: Anvil tests for Switch Widget`, { tags: ["@tag.Anvil", "@tag.Visual"] }, () => { diff --git a/app/client/cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilTableWidgetSnapshot_spec.ts b/app/client/cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilTableWidgetSnapshot_spec.ts index e5edcb37d91..87e1c2a6b4e 100644 --- a/app/client/cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilTableWidgetSnapshot_spec.ts +++ b/app/client/cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilTableWidgetSnapshot_spec.ts @@ -4,7 +4,8 @@ import { anvilSnapshot, } from "../../../../../support/Objects/ObjectsCore"; -describe( +// TODO: Enable when issue(github.com/appsmithorg/appsmith/issues/36419) is solved. +describe.skip( `${ANVIL_EDITOR_TEST}: Anvil tests for Table Widget`, { tags: ["@tag.Anvil", "@tag.Visual"] }, () => { diff --git a/app/client/cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilToolbarButtonWidgetSnapshot_spec.ts b/app/client/cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilToolbarButtonWidgetSnapshot_spec.ts index ecf7a60d051..ef99aeab293 100644 --- a/app/client/cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilToolbarButtonWidgetSnapshot_spec.ts +++ b/app/client/cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilToolbarButtonWidgetSnapshot_spec.ts @@ -4,7 +4,8 @@ import { anvilSnapshot, } from "../../../../../support/Objects/ObjectsCore"; -describe( +// TODO: Enable when issue(github.com/appsmithorg/appsmith/issues/36419) is solved. +describe.skip( `${ANVIL_EDITOR_TEST}: Anvil tests for Toolbar Button Widget`, { tags: ["@tag.Anvil", "@tag.Visual"] }, () => { diff --git a/app/client/cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilZoneSectionWidgetSnapshot_spec.ts b/app/client/cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilZoneSectionWidgetSnapshot_spec.ts index 336d17180eb..bd1bcf0d243 100644 --- a/app/client/cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilZoneSectionWidgetSnapshot_spec.ts +++ b/app/client/cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilZoneSectionWidgetSnapshot_spec.ts @@ -4,7 +4,8 @@ import { anvilSnapshot, } from "../../../../../support/Objects/ObjectsCore"; -describe( +// TODO: Enable when issue(github.com/appsmithorg/appsmith/issues/36419) is solved. +describe.skip( `${ANVIL_EDITOR_TEST}: Anvil tests for Zone and Section Widget`, { tags: ["@tag.Anvil", "@tag.Visual"] }, () => {