From 7c61af0460ee14f52b62df642d58e7c2d5e4bbd8 Mon Sep 17 00:00:00 2001 From: Hetu Nandu Date: Wed, 5 Jul 2023 15:44:28 +0530 Subject: [PATCH] updates --- CODEOWNERS | 1 + app/client/cypress/support/commands.js | 2 +- .../com/appsmith/server/featureflags/FeatureFlagEnum.java | 1 - .../src/main/resources/features/init-flags.xml | 5 ----- 4 files changed, 2 insertions(+), 7 deletions(-) diff --git a/CODEOWNERS b/CODEOWNERS index 6a09e555431..cb7f2daf14f 100644 --- a/CODEOWNERS +++ b/CODEOWNERS @@ -38,6 +38,7 @@ app/client/src/ee/pages/Editor/NavigationSettings/LogoInput.tsx @dhruvikn # New Developers Pod app/client/src/ce/entities/FeatureFlag.ts @hetunandu app/client/src/ee/entities/FeatureFlag.ts @hetunandu +app/server/appsmith-server/src/main/resources/features/init-flags.xml @hetunandu # UI Builders Pod app/client/generators/* @appsmithorg/ui-builders diff --git a/app/client/cypress/support/commands.js b/app/client/cypress/support/commands.js index 14659800c37..60dc17086a4 100644 --- a/app/client/cypress/support/commands.js +++ b/app/client/cypress/support/commands.js @@ -1127,7 +1127,7 @@ Cypress.Commands.add("startServerAndRoutes", () => { }).as("postTenant"); cy.intercept("PUT", "/api/v1/git/discard/app/*").as("discardChanges"); cy.intercept("GET", "/api/v1/libraries/*").as("getLibraries"); - featureFlagIntercept({}); + featureFlagIntercept({}, false); }); Cypress.Commands.add("startErrorRoutes", () => { diff --git a/app/server/appsmith-server/src/main/java/com/appsmith/server/featureflags/FeatureFlagEnum.java b/app/server/appsmith-server/src/main/java/com/appsmith/server/featureflags/FeatureFlagEnum.java index c099767c3b3..6caf28956d7 100644 --- a/app/server/appsmith-server/src/main/java/com/appsmith/server/featureflags/FeatureFlagEnum.java +++ b/app/server/appsmith-server/src/main/java/com/appsmith/server/featureflags/FeatureFlagEnum.java @@ -24,7 +24,6 @@ public enum FeatureFlagEnum { // ------------------- These are actual feature flags meant to be used across the product ----------------------- // release_datasource_environments_enabled, - MULTIPLE_PANES, APP_NAVIGATION_LOGO_UPLOAD, APP_EMBED_VIEW_HIDE_SHARE_SETTINGS_VISIBILITY, diff --git a/app/server/appsmith-server/src/main/resources/features/init-flags.xml b/app/server/appsmith-server/src/main/resources/features/init-flags.xml index b9d7653632f..a75d426d2bb 100644 --- a/app/server/appsmith-server/src/main/resources/features/init-flags.xml +++ b/app/server/appsmith-server/src/main/resources/features/init-flags.xml @@ -10,11 +10,6 @@ value="me-eng1@appsmith.com,me-eng2@appsmith.com,me-qa1@appsmith.com,me-qa2@appsmith.com,me-demo@appsmith.com"/> - - - - -