Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Diagnose tool #251

Merged
merged 2 commits into from
Sep 4, 2020
Merged

Diagnose tool #251

merged 2 commits into from
Sep 4, 2020

Conversation

adamyeats
Copy link
Contributor

@adamyeats adamyeats commented Aug 31, 2020

Closes #24.

This adds the long-awaited diagnose CLI. In a new app, this can now be used by running npx appsignal-diagnose from your project directory after @appsignal/nodejs is installed.

As @appsignal/nodejs doesn't use a config file, it relies on the correct environment variables being set at the time. If unset, you can use the command like this: APPSIGNAL_PUSH_API_KEY="<key>" npx appsignal-diagnose

At the moment, the paths key has been omitted as this might take a little extra time.

@adamyeats adamyeats requested a review from thijsc August 31, 2020 13:55
@adamyeats adamyeats self-assigned this Aug 31, 2020
@thijsc
Copy link
Member

thijsc commented Sep 1, 2020

Looking good so far! I see it's still in draft state, do you expect me to do a review already?

@adamyeats adamyeats force-pushed the diagnose-tool branch 5 times, most recently from c376bb0 to 01f3821 Compare September 2, 2020 12:25
@adamyeats adamyeats marked this pull request as ready for review September 2, 2020 12:26
@adamyeats
Copy link
Contributor Author

@thijsc This is now ready for review.

@backlog-helper

This comment has been minimized.

@backlog-helper
Copy link

backlog-helper bot commented Sep 4, 2020

While performing the daily checks some issues were found with this Pull Request.


New issue guide | Backlog management | Rules | Feedback

Copy link
Member

@thijsc thijsc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made a suggestion on the text, otherwise good to go.

packages/nodejs/bin/diagnose Outdated Show resolved Hide resolved
Co-authored-by: Thijs Cadier <thijs@appsignal.com>
@adamyeats adamyeats merged commit 90cb3a1 into main Sep 4, 2020
@adamyeats adamyeats deleted the diagnose-tool branch September 4, 2020 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Diagnose function
2 participants