Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check if we support Bun #874

Open
3 of 7 tasks
unflxw opened this issue Mar 24, 2023 · 6 comments
Open
3 of 7 tasks

Check if we support Bun #874

unflxw opened this issue Mar 24, 2023 · 6 comments

Comments

@unflxw
Copy link
Contributor

unflxw commented Mar 24, 2023

Bun is a new JavaScript run-time written in Zig. It's designed to be Node-compatible, including NAPI -- so we probably support it.

Timebox: 0.5 days

To do

  • See if we already support Bun
    • If we support it
      • Document it
      • Create an issue to add it to the build matrix
    • If we don't support it: [Timebox: ?]
      • Try to understand why and document it here
      • Fix it if possible
@backlog-helper
Copy link

backlog-helper bot commented Mar 24, 2023

✔️ All good!

New issue guide | Backlog management | Rules | Feedback

@unflxw unflxw self-assigned this May 30, 2023
@unflxw
Copy link
Contributor Author

unflxw commented Jun 2, 2023

Promising, but not there yet.

The AppSignal installer works fine (although it is hardcoded to run npm install — this will fail for users who have Bun and not Node)

They do want to eventually support all of Node, including NAPI, but for now initialising the AppSignal client fails with a SIGSEGV from the extension. I didn't look any deeper into why.

They also don’t yet support the necessary hooks on the JS side for require-in-the-middle to work (which is what OpenTelemetry instrumentations use internally to intercept imports) so even if the extension and agent initialised correctly, nothing would be instrumented.

Screenshot 2023-06-02 at 14 11 06

@unflxw unflxw closed this as completed Jun 2, 2023
@unflxw unflxw self-assigned this Jun 2, 2023
@afxal
Copy link

afxal commented Nov 1, 2024

Bump, would this be explored in future?

@unflxw
Copy link
Contributor Author

unflxw commented Nov 1, 2024

Hi @afxal! We'd like to support this in the future, though we can't commit to a specific timeframe.

It seems that Bun recently added support for require-in-the-middle, so that's one of the pieces of the puzzle we need. It might be time to give this another try.

@unflxw unflxw reopened this Nov 1, 2024
@unflxw unflxw removed their assignment Nov 1, 2024
@afxal
Copy link

afxal commented Nov 1, 2024

@unflxw appreciate the fast response, i'll keep an eye on this issue. 🫡

@shairyar
Copy link
Member

shairyar commented Nov 8, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants