-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support node-redis 4.x.x #567
Labels
Comments
Moving this to backlog while we wait for opentelemetry research results. https://github.com/appsignal/integration-guide/issues/47 |
Thx 🙏🙏🙏 |
We would like to see support for it as well 👍 |
Related #366 |
OpenTelemetry doesn't support version 4 yet either.
|
Supported in v3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Background
As reported in: https://github.com/appsignal/support/issues/184, before @appsignal/nodejs@2.3.1, users with
redis
v4.x.x package in their apps may experiment crashes when starting up and/or other related issues.The problem
This was caused due to the way the version check was done for the Redis instrumentation. Here's the PR that fixes it: #566
Adapting the instrumentation to version 4.x.x is not a simple task. The
node-redis
package has completely changed its structure and interface. Now it doesn't export theRedisClient
module, which was needed to wrap theinternal_send_command
function to add our instrumentation withshimmer
.The proposal(s)
Now that we're planning to keep moving to an OpenTelemetry oriented solution, I think it's best to give support to the Redis instrumentation using OpenTelemetry Redis plugin
The text was updated successfully, but these errors were encountered: