Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support node-redis 4.x.x #567

Closed
luismiramirez opened this issue Jan 26, 2022 · 6 comments
Closed

Support node-redis 4.x.x #567

luismiramirez opened this issue Jan 26, 2022 · 6 comments
Labels

Comments

@luismiramirez
Copy link
Member

Background

As reported in: https://github.com/appsignal/support/issues/184, before @appsignal/nodejs@2.3.1, users with redis v4.x.x package in their apps may experiment crashes when starting up and/or other related issues.

The problem

This was caused due to the way the version check was done for the Redis instrumentation. Here's the PR that fixes it: #566

Adapting the instrumentation to version 4.x.x is not a simple task. The node-redis package has completely changed its structure and interface. Now it doesn't export the RedisClient module, which was needed to wrap the internal_send_command function to add our instrumentation with shimmer.

The proposal(s)

Now that we're planning to keep moving to an OpenTelemetry oriented solution, I think it's best to give support to the Redis instrumentation using OpenTelemetry Redis plugin

@tombruijn
Copy link
Member

Moving this to backlog while we wait for opentelemetry research results. https://github.com/appsignal/integration-guide/issues/47

@v-ruiz
Copy link

v-ruiz commented Jan 28, 2022

Thx 🙏🙏🙏

@jimaek
Copy link

jimaek commented Feb 21, 2022

We would like to see support for it as well 👍

@tombruijn
Copy link
Member

Related #366

@tombruijn
Copy link
Member

OpenTelemetry doesn't support version 4 yet either.

^2.6.0 || ^3.0.0 (version 4 is not yet supported)

@luismiramirez
Copy link
Member Author

Supported in v3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants