Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignores APPSIGNAL_APP_ENV environment variable #129

Closed
simonrussell opened this issue May 6, 2020 · 1 comment · Fixed by #155
Closed

Ignores APPSIGNAL_APP_ENV environment variable #129

simonrussell opened this issue May 6, 2020 · 1 comment · Fixed by #155
Assignees
Labels

Comments

@simonrussell
Copy link

It seems that the APPSIGNAL_APP_ENV environment variable doesn't have the effect it's supposed to (as per the other integrations). Our staging environment runs with NODE_ENV set to production, which is fairly common. On our Ruby services we use APPSIGNAL_APP_ENV to set it to the right thing. This doesn't work in the Node integration.

Looking through the code, it seems that the APPSIGNAL_APP_ENV environment variable is mapped through to env on the options, but this isn't actually ever used -- elsewhere, NODE_ENV is used, defaulting to development.

@backlog-helper
Copy link

While performing the daily checks some issues were found with this issue.

  • This issue has not had any activity in 14 days. Please provide a status update if it is still relevant. Closed it if it is no longer relevant. Or move it to another column if it's blocked or requires another look at it. - (More info)

New issue guide | Backlog management | Rules | Feedback

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants