Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Appsignal requires options parameter #125

Closed
simonrussell opened this issue May 4, 2020 · 1 comment
Closed

Appsignal requires options parameter #125

simonrussell opened this issue May 4, 2020 · 1 comment
Assignees
Labels

Comments

@simonrussell
Copy link

In the documentation (and reading through the code) it seems like the intent is that all parameters to the main Appsignal entrypoint are optional -- they can be supplied with environment variables. However, the Typescript definition doesn't let you leave out the argument entirely, and if you do supply it, you are required to give app name and API key -- these values will override the environment variables.

I'd like to use this with app name fixed in the code, but the API key and environment name supplied in environment variables. I could do this by hand (Process.env) but it seems like this is an oversight?

@adamyeats adamyeats self-assigned this May 4, 2020
@adamyeats adamyeats added the bug label May 4, 2020
@adamyeats
Copy link
Contributor

@simonrussell You are correct that this should have been the case but for some reason was not, and that was also fixed in 0.3.3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants