Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exit errors in background namespace generate a unique error every time #76

Closed
tombruijn opened this issue Jan 16, 2017 · 2 comments
Closed
Assignees
Milestone

Comments

@tombruijn
Copy link
Member

tombruijn commented Jan 16, 2017

This causes some 11k errors to be reported for one user (along with as many notifications 😖 ).

Reported reproducible code:

$ iex -S mix
> Task.async(fn -> Process.sleep(1000) end) |> Task.await(500)

Cannot reproduce on 0.9.2 (which user uses) or 0.10.0

As reported in https://app.intercom.io/a/apps/yzor8gyw/inbox/conversation/7786937331

@tombruijn tombruijn added this to the Elixir 1.0 milestone Jan 16, 2017
@arjan
Copy link
Contributor

arjan commented Jan 16, 2017

This is how it's reproducible:

:proc_lib.spawn_link(fn -> Task.async(fn -> Process.sleep(1000) end) |> Task.await(500) end)

It indeed generates a new error message each time. This is because the process id is part of the error reason string, and the pid is different each time.

The best way to fix this is probably replacing the #PID<0.32.11> parts of the string with something like #PID<...>.

@arjan arjan self-assigned this Jan 16, 2017
@tombruijn
Copy link
Member Author

Fixed by #78

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants