You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The API (and implementation) of org.approvaltests.JsonApprovals.verifyJson does not provide a variant with reorderJson functionality and gsonBuilder parameter, resulting in unexpected changes of the output - fields are missing due to the default behavior of the GsonBuilder to skip NULL fields.
publicstaticvoidverifyJson(Stringjson, booleanreorderJson);
publicstaticvoidverifyJson(Stringjson, booleanreorderJson, Optionsoptions);
// no way to configure both reorderJson = true and gsonBuilderpublicstaticvoidverifyAsJson(Objecto, Function1<GsonBuilder, GsonBuilder> gsonBuilder);
publicstaticvoidverifyAsJson(Objecto, Function1<GsonBuilder, GsonBuilder> gsonBuilder, Optionsoptions);
Btw I think that the API is not going to scale well with these different parameters.
I'd propose to merge the configuration parameters into a combined JsonOptions structure.
Thank you for the tooling! I really appreciate such a zero-config snapshotting functionality :)
The text was updated successfully, but these errors were encountered:
The API (and implementation) of
org.approvaltests.JsonApprovals.verifyJson
does not provide a variant withreorderJson
functionality andgsonBuilder
parameter, resulting in unexpected changes of the output - fields are missing due to the default behavior of the GsonBuilder to skip NULL fields.Btw I think that the API is not going to scale well with these different parameters.
I'd propose to merge the configuration parameters into a combined
JsonOptions
structure.Thank you for the tooling! I really appreciate such a zero-config snapshotting functionality :)
The text was updated successfully, but these errors were encountered: