Skip to content

HTTP proxy support #63

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 13 commits into
base: master
Choose a base branch
from
Open

Conversation

loafoe
Copy link
Contributor

@loafoe loafoe commented Jan 23, 2021

  • Supports HTTP proxies in front of Bastion/Proxy servers
  • Makes this work behind corporate proxies

@codecov-io
Copy link

codecov-io commented Jan 23, 2021

Codecov Report

Merging #63 (e389293) into master (355f45a) will decrease coverage by 24.22%.
The diff coverage is 7.69%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master      #63       +/-   ##
===========================================
- Coverage   83.55%   59.32%   -24.23%     
===========================================
  Files           1        2        +1     
  Lines         225      327      +102     
===========================================
+ Hits          188      194        +6     
- Misses         21      114       +93     
- Partials       16       19        +3     
Impacted Files Coverage Δ
http_proxy.go 0.00% <0.00%> (ø)
easyssh.go 71.32% <16.32%> (-12.24%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ce04db7...e389293. Read the comment docs.

@loafoe
Copy link
Contributor Author

loafoe commented Jan 23, 2021

I wanted to rename the Proxy field to Bastion but this will break compatibility. I hope to improve coverage as well.

@appleboy
Copy link
Owner

I will take look at it. Can you resolve the conflicts?

@loafoe
Copy link
Contributor Author

loafoe commented May 26, 2021

Yep, will look into resolving conflicts shortly

@codecov-commenter
Copy link

codecov-commenter commented May 26, 2021

Codecov Report

Merging #63 (58f279c) into master (e954c88) will decrease coverage by 24.22%.
The diff coverage is 7.69%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master      #63       +/-   ##
===========================================
- Coverage   83.55%   59.32%   -24.23%     
===========================================
  Files           1        2        +1     
  Lines         225      327      +102     
===========================================
+ Hits          188      194        +6     
- Misses         21      114       +93     
- Partials       16       19        +3     
Impacted Files Coverage Δ
http_proxy.go 0.00% <0.00%> (ø)
easyssh.go 71.32% <16.32%> (-12.24%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e954c88...58f279c. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants