refactor: refactor error handling and add print statements in file operations

- Remove error handling code in `proxy.go`
- Add `fmt.Println("success")` in `proxy.go`
- Remove error handling code in `scp.go`
- Add `fmt.Println("success")` in `scp.go`
- Remove `fmt.Println("don is :", done, "stdout is :", stdout, "; stderr is :", stderr)` in `ssh.go`
- Add `fmt.Println("don is :", done, "stdout is :", stdout, "; stderr is :", stderr)` in `ssh.go`
- Remove `fmt.Println("err: " + err.Error())` and add `panic("err: " + err.Error())` in `stream.go`

Signed-off-by: Bo-Yi Wu <appleboy.tw@gmail.com>

Author: appleboy

example/proxy/proxy.go

@@ -24,11 +24,8 @@ func main() {
 	// Call Scp method with file you want to upload to remote server.
 	// Please make sure the `tmp` floder exists.
 	err := ssh.Scp("/root/source.csv", "/tmp/target.csv")
-
-	// Handle errors
 	if err != nil {
 		panic("Can't run remote command: " + err.Error())
-	} else {
-		fmt.Println("success")
 	}
+	fmt.Println("success")
 }

example/scp/scp.go

@@ -18,11 +18,9 @@ func main() {
 	// Call Scp method with file you want to upload to remote server.
 	// Please make sure the `tmp` floder exists.
 	err := ssh.Scp("/root/source.csv", "/tmp/target.csv")
-
 	// Handle errors
 	if err != nil {
 		panic("Can't run remote command: " + err.Error())
-	} else {
-		fmt.Println("success")
 	}
+	fmt.Println("success")
 }

example/ssh/ssh.go

@@ -48,7 +48,6 @@ func main() {
 	// Handle errors
 	if err != nil {
 		panic("Can't run remote command: " + err.Error())
-	} else {
-		fmt.Println("don is :", done, "stdout is :", stdout, ";   stderr is :", stderr)
 	}
+	fmt.Println("don is :", done, "stdout is :", stdout, ";   stderr is :", stderr)
 }

example/stream/stream.go

@@ -22,30 +22,29 @@ func main() {
 	// Handle errors
 	if err != nil {
 		panic("Can't run remote command: " + err.Error())
-	} else {
-		// read from the output channel until the done signal is passed
-		isTimeout := true
-	loop:
-		for {
-			select {
-			case isTimeout = <-doneChan:
-				break loop
-			case outline := <-stdoutChan:
-				fmt.Println("out:", outline)
-			case errline := <-stderrChan:
-				fmt.Println("err:", errline)
-			case err = <-errChan:
-			}
+	}
+	// read from the output channel until the done signal is passed
+	isTimeout := true
+loop:
+	for {
+		select {
+		case isTimeout = <-doneChan:
+			break loop
+		case outline := <-stdoutChan:
+			fmt.Println("out:", outline)
+		case errline := <-stderrChan:
+			fmt.Println("err:", errline)
+		case err = <-errChan:
 		}
+	}
 
-		// get exit code or command error.
-		if err != nil {
-			fmt.Println("err: " + err.Error())
-		}
+	// get exit code or command error.
+	if err != nil {
+		panic("err: " + err.Error())
+	}
 
-		// command time out
-		if !isTimeout {
-			fmt.Println("Error: command timeout")
-		}
+	// command time out
+	if !isTimeout {
+		fmt.Println("Error: command timeout")
 	}
 }