Disfavor String.init(platformString: UnsafePointer<CChar>) #161
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@swift-ci please test |
jmschonfeld
force-pushed
the
string-init-ambiguity
branch
from
7afe0bd to
dd45c80
Compare
Contributor
|
@swift-ci please test |
glessard
reviewed
May 2, 2024
Contributor
glessard
left a comment
glessard
left a comment
There was a problem hiding this comment.
It's unfortunate that we need this, but it does resolve the problem.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change disfavors
String(platformString:)so that it is not ambiguous withString(cString:)when the initializer is specified without noting the label (i.e. in usages such assomeUnsafePointer.map(String.init)Resolves rdar://127408859