Skip to content

Additional unit tests for OpenAPIObjectContainer #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 3, 2023
Merged

Additional unit tests for OpenAPIObjectContainer #24

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9297cc4
Support nested values in OpenAPIObjectContainer
rboyce Jul 13, 2023
7439e28
Merge branch 'main' into anyValueContainer
czechboy0 Aug 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
92 changes: 92 additions & 0 deletions Tests/OpenAPIRuntimeTests/Base/Test_OpenAPIValue.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -193,4 +193,96 @@ final class Test_OpenAPIValue: Test_Runtime {
XCTAssertEqual(value[0] as? String, "one")
XCTAssertEqual(value[1] as? [String: Int], ["two": 2])
}

func testEncoding_objectNested_success() throws {

struct Foo: Encodable {
var bar: String
var dict: OpenAPIObjectContainer = .init()
}

do {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this extra do scope here?

let value = Foo(
bar: "hi",
dict: try .init(unvalidatedValue: [
"baz": "bar",
"number": 1,
"nestedArray": [
1,
[
"k": "v"
],
] as [(any Sendable)?],
"nestedDict": [
"nested": 2
],
])
)
let encoder: JSONEncoder = .init()
encoder.outputFormatting = [.prettyPrinted, .sortedKeys]
let data = try encoder.encode(value)
XCTAssertEqual(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make it consistent with the other tests by using the utility functions that does the encoding/decoding and equality checks.

String(decoding: data, as: UTF8.self),
#"""
{
"bar" : "hi",
"dict" : {
"baz" : "bar",
"nestedArray" : [
1,
{
"k" : "v"
}
],
"nestedDict" : {
"nested" : 2
},
"number" : 1
}
}
"""#
)
}
}

func testDecodeEncodeRoundTrip_objectNested_success() throws {

struct Foo: Codable {
var bar: String
var dict: OpenAPIObjectContainer = .init()
}

do {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here about the do scope.

let data = Data(
#"""
{
"bar" : "hi",
"dict" : {
"baz" : "bar",
"nestedArray" : [
1,
{
"k" : "v"
}
],
"nestedDict" : {
"nested" : 2
},
"number" : 1
}
}
"""#
.utf8
)
let decoded = try JSONDecoder().decode(Foo.self, from: data)
let nestedDict = try XCTUnwrap(decoded.dict.value["nestedDict"] as? [String: Any?])
let nestedValue = try XCTUnwrap(nestedDict["nested"] as? Int)
XCTAssertEqual(nestedValue, 2)

let encoder: JSONEncoder = .init()
encoder.outputFormatting = [.prettyPrinted, .sortedKeys]
let encodedData = try encoder.encode(decoded)
XCTAssertEqual(encodedData, data)
}
}
}