fix: Correct data type of date-formatted strings #137
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While OpenAPI date-formatted strings do not contain information about a specific time, `Foundation.Date` only supports full timestamps. Also, `ISO8601DateTranscoder` does not support parsing ISO-8601 dates without time information. This commit introduces the expected behavior that date-only strings are not automatically decoded.
|
Technically, this will change which type we generate and could be source breaking, but the previously generated code never actually worked, so I'm leaning towards not requiring a minor here, WDYT @simonjbeaumont? |
simonjbeaumont
approved these changes
Jul 21, 2023
|
@swift-server-bot add to allowlist |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
While OpenAPI date-formatted strings do not contain information about a specific time,
Foundation.Dateonly supports full timestamps. Also,ISO8601DateTranscoderdoes not support parsing ISO-8601 dates without time information. This commit introduces the expected behavior that date-only strings are not automatically decoded toFoundation.Dateobjects. This PR fixes issue #136.Modifications
.datewas removed from the case-condition that definedFoundation.Dateas the applicable type name.Result
date-formatted strings are no longer represented asFoundation.Datebut asSwift.Stringobjects.Test Plan
Tests were adapted so that the correct Swift type for
date-formatted strings is ensured.