Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename Channel._unsafe to Channel._channelCore #820

Merged
merged 2 commits into from
Feb 14, 2019

Conversation

weissi
Copy link
Member

@weissi weissi commented Feb 12, 2019

Motivation:

_unsafe is non-descriptive

Modifications:

  • rename Channel._unsafe to Channel._channelCore

Result:

clearer API

@weissi weissi added the ⚠️ semver/major Breaks existing public API. label Feb 12, 2019
@weissi weissi added this to the 2.0.0 milestone Feb 12, 2019
@Lukasa
Copy link
Contributor

Lukasa commented Feb 13, 2019

_ChannelCore is public API: implementing it is necessary to implement a new Channel.

@weissi
Copy link
Member Author

weissi commented Feb 13, 2019

@Lukasa yeah, it's implementor's public API but not for users. But I think you're right. Maybe we should leave the type name alone (ie. ChannelCore) and just rename the property from _unsafe to _channelCore. What do you think?

@Lukasa
Copy link
Contributor

Lukasa commented Feb 14, 2019

I think that's a good plan. 👍

Motivation:

_unsafe is non-descriptive

Modifications:

- rename Channel._unsafe to Channel._channelCore

Result:

clearer API
@weissi weissi force-pushed the jw-underscore-channelcore branch from a329505 to bd1546e Compare February 14, 2019 12:03
@weissi weissi changed the title underscore for _ChannelCore rename Channel._unsafe to Channel._channelCore Feb 14, 2019
@weissi
Copy link
Member Author

weissi commented Feb 14, 2019

@Lukasa updated, thanks

@weissi weissi merged commit 03aa0bd into apple:master Feb 14, 2019
@weissi weissi deleted the jw-underscore-channelcore branch February 14, 2019 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⚠️ semver/major Breaks existing public API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants