Return response when header validation fails #3346
Open
+136
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lukasa
reviewed
Aug 13, 2025
| self.sendResponseOnInvalidHeader = false | ||
| } | ||
|
|
||
| public init(sendResponseOnInvalidHeader: Bool) { |
There was a problem hiding this comment.
I wonder if we should create a configuration structure. That would let us extend this again in future without needing to provide more initializers and more pipeline builders.
There was a problem hiding this comment.
Happy to add that in. Would you envisage a config type with an initialiser that takes no arguments and each one can be set individually?
There was a problem hiding this comment.
Ok updated - I've only added the new configuration option to avoid an explosion of deprecations and confusing APIs. And I'm sure we need to refine the naming
There was a problem hiding this comment.
I think we should pass the new config field to this initializer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow the
NIOHTTPResponseHeadersValidatorto be configured to return a response if the header validation fails. This allows something to be returned to client and can fix issues where proxies might mark a node as bad if aRSTis returned. This has to be done in the validator since all future writes are dropped so any error handler won't be able to catch the error and write out a fallback response.I haven't touched trailer validation, not sure if you want me to look at that. I don't know if an empty end would be valid as other data would have been already written to the channel.