allow completely single-threaded NIO programs #1499
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lukasa
requested changes
May 1, 2020
glbrntt
reviewed
May 1, 2020
weissi
force-pushed
the
jw-single-threaded-nio
branch
from
89b5271 to
bca1a32
Compare
|
@glbrntt / @Lukasa I agree that it's weird to call this on I felt it's not really worth adding a new top-level namespace for a function that'll be as rarely used as this one so I put it into MTELG and thought we can always (deprecate) move it elsewhere in the future. But 100% open to moving it. |
Davidde94
reviewed
May 1, 2020
|
@swift-server-bot test this please |
|
this is great @weissi, can be very useful in one of our projects. thanks! |
weissi
force-pushed
the
jw-single-threaded-nio
branch
from
481d919 to
19ed719
Compare
Motivation: Usually, you spawn a new MultiThreadedEventLoopGroup to run NIO programs. But if you're a very simple command line utility, that may not be necessary, so why not just re-use the main thread? Modifications: Allow taking over threads and making them EventLoops. Result: Fewer threads if you want.
weissi
force-pushed
the
jw-single-threaded-nio
branch
from
19ed719 to
a3b0d29
Compare
Lukasa
approved these changes
May 11, 2020
pull bot
pushed a commit
to scope-demo/swift-nio
that referenced
this pull request
May 11, 2020
Motivation: Usually, you spawn a new MultiThreadedEventLoopGroup to run NIO programs. But if you're a very simple command line utility, that may not be necessary, so why not just re-use the main thread? Modifications: Allow taking over threads and making them EventLoops. Result: Fewer threads if you want. Co-authored-by: Cory Benfield <lukasa@apple.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Usually, you spawn a new MultiThreadedEventLoopGroup to run NIO
programs. But if you're a very simple command line utility, that may not
be necessary, so why not just re-use the main thread?
Modifications:
Allow taking over threads and making them EventLoops.
Result:
Fewer threads if you want.