fix https fail on Android #453
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lukasa
reviewed
Dec 19, 2023
Sources/NIOSSL/AndroidCABundle.swift
Outdated
| /// Some distributions do not ship CA directories: as such, it is not a problem if a distribution that is present in rootCAFileSearchPaths | ||
| /// is not present in this list. | ||
| private let rootCADirectorySearchPaths = [ | ||
| "/system/etc/security/cacerts", // Android |
There was a problem hiding this comment.
@finagolfin does this path look appropriate to you? It's hard for me to validate this logic from here.
There was a problem hiding this comment.
I have not done anything with this before, but it looks like the path is correct.
|
from Android14, a new path is added for updating CA certificates. so I just updated the commit to read this new path first or else the older one. |
Lukasa
approved these changes
Mar 26, 2024
|
@swift-server-bot test this please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix https handshake fail on Android platform.
An example error: