Skip to content

Enable strict concurrency #53

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Dec 5, 2024
Merged

Enable strict concurrency #53

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
d1ddd52
Enable strict concurrency
clintonpi Dec 4, 2024
85245dd
Add `Sendable` conformance to `StructuredFieldType`
clintonpi Dec 4, 2024
e3f15af
Copy over `CommandLine.arguments` instead of referencing
clintonpi Dec 4, 2024
b694b36
Mark `Flags` as `Sendable`
clintonpi Dec 4, 2024
8f0c94c
Swap concurrency-unsafe `CommandLine.arguments` with `ProcessInfo.pro…
clintonpi Dec 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions Package.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,3 +45,9 @@ let package = Package(
),
]
)

for target in package.targets {
var settings = target.swiftSettings ?? []
settings.append(.enableExperimentalFeature("StrictConcurrency=complete"))
target.swiftSettings = settings
}
2 changes: 1 addition & 1 deletion Sources/StructuredFieldValues/StructuredFieldValue.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ public protocol StructuredFieldValue: Codable {
}

/// The kinds of header fields used in HTTP Structured Headers.
public enum StructuredFieldType {
public enum StructuredFieldType: Sendable {
/// An item field consists of a single item, optionally with parameters.
case item

Expand Down
3 changes: 2 additions & 1 deletion Sources/sh-parser/main.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,9 @@ struct Flags {
init() {
// Default to item
self.headerType = .item
let arguments = ProcessInfo.processInfo.arguments

for argument in CommandLine.arguments.dropFirst() {
for argument in arguments.dropFirst() {
switch argument {
case "--dictionary":
self.headerType = .dictionary
Expand Down
Loading