[RFC 9651] Add support for Date type to RawStructuredFieldValues #41
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: [RFC 9651](https://www.ietf.org/rfc/rfc9651.html) added the Date Structured Type. Modifications: - Implement the parser and serializer for Date in the RawStructuredFieldValues module. Result: The RawStructuredFieldValues module will support the Date type.
Lukasa
reviewed
Oct 25, 2024
| default: | ||
| throw StructuredHeaderError.invalidItem | ||
| } | ||
| } | ||
|
|
||
| private mutating func _parseAnIntegerOrDecimal() throws -> RFC9651BareItem { | ||
| private mutating func _parseAnIntegerOrDecimal(isDate: Bool = false) throws -> RFC9651BareItem { |
There was a problem hiding this comment.
This shouldn't be defaulted: we'd rather see the explicit false everywhere I think.
|
|
||
| // Then, serialize as integer. | ||
| guard let wideInt = Int64(exactly: date), validIntegerRange.contains(wideInt) else { | ||
| throw StructuredHeaderError.invalidIntegerOrDecimal |
There was a problem hiding this comment.
Probably better to throw invalidDate here.
clintonpi
added a commit
to clintonpi/swift-http-structured-headers
that referenced
this pull request
Nov 14, 2024
…alues (apple#41) Motivation: [RFC 9651](https://www.ietf.org/rfc/rfc9651.html) added the Display String Structured Type. Modifications: - Implement the parser and serializer for Display String in the RawStructuredFieldValues module. Result: The RawStructuredFieldValues module will support the Display String type.
clintonpi
added a commit
to clintonpi/swift-http-structured-headers
that referenced
this pull request
Nov 14, 2024
…alues (apple#41) Motivation: [RFC 9651](https://www.ietf.org/rfc/rfc9651.html) added the Display String Structured Type. Modifications: - Implement the parser and serializer for Display String in the RawStructuredFieldValues module. Result: The RawStructuredFieldValues module will support the Display String type.
clintonpi
added a commit
to clintonpi/swift-http-structured-headers
that referenced
this pull request
Nov 14, 2024
…alues (apple#41) Motivation: [RFC 9651](https://www.ietf.org/rfc/rfc9651.html) added the Display String Structured Type. Modifications: - Implement the parser and serializer for Display String in the RawStructuredFieldValues module. Result: The RawStructuredFieldValues module will support the Display String type.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
RFC 9651 added the Date Structured Type.
Modifications:
Result:
The RawStructuredFieldValues module will support the Date type.