Raise minimum supported Swift version from 5.4 to 5.5 #27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lukasa
requested changes
Sep 28, 2022
docker/docker-compose.2204.57.yaml
Outdated
| image: swift-http-structured-headers:22.04-5.7 | ||
| build: | ||
| args: | ||
| base_image: "swift:5.7-jammy" |
There was a problem hiding this comment.
I think we're supposed to use the ubuntu_version/swift_version split, not base_image.
There was a problem hiding this comment.
Ah okay, I just modified the existing 5.7 yaml. Looks like all the others use ubuntu_version/swift_version though.
There was a problem hiding this comment.
Is base_image just used for nightlies?
Motivation: We periodically drop support for older Swift versions. Now that 5.7 has been released, 5.4 can be dropped. Modifications: - Remove 5.4 specific Package.swift and docker-compose - Update the 5.7 docker-compose to use the released 5.7 and move from focal (2004) to jammy (2204) Results: Minimum Swift version is 5.5
Lukasa
approved these changes
Sep 28, 2022
|
CI updated. @swift-server-bot test this please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
We periodically drop support for older Swift versions. Now that 5.7 has been released, 5.4 can be dropped.
Modifications:
Results:
Minimum Swift version is 5.5