Skip to content

Drop support for Swift 5.2 and 5.3 #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 21, 2022

Conversation

fabianfett
Copy link
Member

As outlined in a Swift forums post in November ’21, SwiftNIO will only support the latest non-patch Swift release and the 2 immediately prior non-patch versions.

In this commit we drop support for Swift 5.2 and 5.3. We update CI for Swift 5.4 to run on bionic instead of focal to ensure that we still test bionic.

@fabianfett fabianfett added the 🆕 semver/minor Adds new public API. label Apr 19, 2022
@fabianfett fabianfett requested review from Lukasa and yim-lee April 19, 2022 10:44
@fabianfett
Copy link
Member Author

@yim-lee Could you please disable the CI for 5.2 and 5.3 and change the CI file for 5.4 from docker/docker-compose.2004.54.yaml to docker/docker-compose.1804.54.yaml.

As outlined in a [Swift forums post in November ’21](https://forums.swift.org/t/swiftnio-swift-version-support/53232), SwiftNIO will only support the latest non-patch Swift release and the 2 immediately prior non-patch versions.

In this commit we drop support for Swift 5.2 and 5.3. We update CI for Swift 5.4 to run on bionic instead of focal to ensure that we still test bionic.
@fabianfett fabianfett force-pushed the ff-drop-swift-5.2-and-5.3 branch from 73df84a to f0167cf Compare April 19, 2022 10:49
Copy link
Contributor

@Lukasa Lukasa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved modulo the CI changes

@yim-lee
Copy link
Member

yim-lee commented Apr 19, 2022

@fabianfett CI changes done.

@yim-lee
Copy link
Member

yim-lee commented Apr 19, 2022

@swift-server-bot test this please

@fabianfett fabianfett merged commit 1494d9e into apple:main Apr 21, 2022
@fabianfett fabianfett deleted the ff-drop-swift-5.2-and-5.3 branch April 21, 2022 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🆕 semver/minor Adds new public API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants