Move away from Foundation.Thread #404
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation In preparation for adopting FoundationEssentials where available, we need to avoid using Thread as that isn't available. To that end, let's bring over NIO's ThreadSpecificVariable wrapper. Modifications Bring over NIO's ThreadSpecificVariable wrapper and supporting code. Result No need for Thread anymore.
simonjbeaumont
approved these changes
Aug 29, 2025
Contributor
simonjbeaumont
left a comment
simonjbeaumont
left a comment
There was a problem hiding this comment.
LGTM once the CMakeLists are updated and formatting CI appeased.
Lukasa
force-pushed
the
cb-avoid-thread
branch
from
b7a0a86 to
c8a23a5
Compare
Lukasa
changed the title
simonjbeaumont
approved these changes
Sep 8, 2025
Lukasa
force-pushed
the
cb-avoid-thread
branch
from
65829d4 to
b7a0a86
Compare
simonjbeaumont
approved these changes
Sep 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
In preparation for adopting FoundationEssentials where available, we need to avoid using Thread as that isn't available. To that end, let's bring over NIO's ThreadSpecificVariable wrapper.
Modifications
Bring over NIO's ThreadSpecificVariable wrapper and supporting code.
Result
No need for Thread anymore.