Remove security backend #373
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: Depending on the platform Swift Crypto Extras might use an implementation backed by Security.framework, specifically for RSA. Since BoringSSL is a necessary dependency on all platforms, we can deduplicate the implementation and keep a single backend. Modifications: Remove the Security.framework implementation and tie the RSA backend to BoringSSL. Result: Swift Crypto Extras always uses the BoringSSL backend for RSA.
Lukasa
approved these changes
Jul 2, 2025
Contributor
Lukasa
left a comment
Lukasa
left a comment
There was a problem hiding this comment.
Love to see a negative diff, great stuff!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Depending on the platform Swift Crypto Extras might use an
implementation backed by
Security.framework, specifically for RSA. SinceBoringSSL is a necessary dependency on all platforms, we can deduplicate
the implementation and keep a single backend.
Modifications:
Remove the
Security.frameworkimplementation and tie the RSA backend toBoringSSL.
Result:
Swift Crypto Extras always uses the BoringSSL backend for RSA.