Replace all Foundation imports with FoundationEssentials #363
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gjcairo
reviewed
Jun 17, 2025
| @_exported import CryptoKit | ||
| #else | ||
|
|
||
| #if CRYPTOKIT_NO_ACCESS_TO_FOUNDATION |
Contributor
There was a problem hiding this comment.
Just checking: does CRYPTOKIT_NO_ACCESS_TO_FOUNDATION imply no access to FoundationEssentials either?
glbrntt
reviewed
Jun 17, 2025
Comment on lines
27
to
+28
| #else | ||
| #if canImport(FoundationEssentials) |
Contributor
There was a problem hiding this comment.
Any reason we shouldn't use #elseif to avoid the extra nesting?
Contributor
Author
There was a problem hiding this comment.
I really didn't want to think that hard about it, honestly, as we had to change a good 150 files.
glbrntt
approved these changes
Jun 18, 2025
This was referenced Sep 24, 2025
Lukasa
added a commit
that referenced
this pull request
Sep 26, 2025
This change updates Crypto to WWDC25 equivalent code. Each of these changes were individually merged to the WWDC25 branch. This includes: - #359 - #363 - #365 - #367 - #368 - #397 - #403 - #410 - #407 - #401 - #415 --------- Co-authored-by: YourMJK <37852512+YourMJK@users.noreply.github.com> Co-authored-by: Si Beaumont <beaumont@apple.com> Co-authored-by: Rick Newton-Rogers <rnro@apple.com> Co-authored-by: Raphael <josephnoir@users.noreply.github.com> Co-authored-by: Evan Wilde <ewilde@apple.com> Co-authored-by: Tim Condon <0xTim@users.noreply.github.com> Co-authored-by: Gus Cairo <gus.cairo@apple.com> Co-authored-by: George Barnett <gbarnett@apple.com> Co-authored-by: Fabrice de Gans <Steelskin@users.noreply.github.com> Co-authored-by: Wojciech Nagrodzki <278594+wnagrodzki@users.noreply.github.com> Co-authored-by: Jesse L. Zamora <xtremekforever@gmail.com> Co-authored-by: aryan-25 <aryan_shah@apple.com> Co-authored-by: Gwynne Raskind <gwynne@vapor.codes> Co-authored-by: 3405691582 <dsk@google.com> Co-authored-by: Paul Toffoloni <69189821+ptoffy@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
FoundationEssentials produces smaller binaries on most platforms.
Modifications:
Where FoundationEssentials is available, import that.
Result:
Improved binary size