Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix version-specific manifest for 5.6..<5.9 #93

Merged
merged 1 commit into from
Jul 19, 2023

Conversation

lorentey
Copy link
Member

This fixes the typo in the name of the Swift 5.6 package manifest, and also adds explicit manifests for Swift 5.7 and 5.8.

The default manifest has to be the 5.9 one, as we want it to get automatically picked up for Swift tool versions 5.10, 5.11, 6.0, 7.5 etc.

The manifest for 5.7 and 5.8 is the same as the one for 5.6. This PR uses symlinks to link all three of them to the same source file, assuming that symlinks are now a thing on every supported platform

Resolves #92.

Checklist

  • I've read the Contribution Guidelines
  • My contributions are licensed under the Swift license.
  • I've followed the coding style of the rest of the project.
  • I've added tests covering all new code paths my change adds to the project (if appropriate).
  • I've verified that my change does not break any existing tests.
  • I've updated the documentation if necessary.

@lorentey lorentey requested review from glessard and Azoy July 18, 2023 22:01
@lorentey
Copy link
Member Author

@swift-ci test

@lorentey lorentey merged commit 2ff28f8 into apple:main Jul 19, 2023
@lorentey lorentey deleted the fix-old-manifests branch July 19, 2023 00:43
@lorentey lorentey added this to the 1.2.0 milestone Sep 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HEAD is currently broken on older Swifts
3 participants