Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Xcode] Don’t use a bridging header in a framework target #87

Merged
merged 1 commit into from
Jun 20, 2023

Conversation

lorentey
Copy link
Member

@lorentey lorentey commented Jun 16, 2023

Oops, that was not intended to work, and in fact it produces warnings in clients.

Instead, change _sa_retain_n and _sa_release_n to Swift calling convention and call them using _silgen_name trickery when in single-module configuration.

Resolves rdar://110860922

Checklist

  • I've read the Contribution Guidelines
  • My contributions are licensed under the Swift license.
  • I've followed the coding style of the rest of the project.
  • I've added tests covering all new code paths my change adds to the project (if appropriate).
  • I've verified that my change does not break any existing tests.
  • I've updated the documentation if necessary.

@lorentey
Copy link
Member Author

@swift-ci test

@lorentey lorentey changed the title [Xcode] Set _AtomicsShims.h as a public header [Xcode] Don’t use a bridging header in a framework target Jun 16, 2023
@lorentey
Copy link
Member Author

@swift-ci test

@lorentey lorentey requested a review from glessard June 16, 2023 03:06
Copy link
Contributor

@glessard glessard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd recommend updating the copyright notices for the changed files, but since I also always forget to do so, I'll abstain from making a recommendation.

Utilities/generate-docs.sh Outdated Show resolved Hide resolved
Oops, that was not intended to work, and in fact it produces warnings in clients.

Instead, change _sa_retain_n and _sa_release_n to Swift calling convention and call them using _silgen_name trickery when in single-module configuration.

Resolves rdar://110860922
@lorentey lorentey merged commit 8bdc853 into apple:main Jun 20, 2023
@lorentey lorentey deleted the fix-header-in-xcodeproj branch June 20, 2023 17:54
@lorentey lorentey added this to the 1.2.0 milestone Sep 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants