Implement next(isolation:) in AsyncAdjacentPairsSequence#390
Open
alex-waldron wants to merge 4 commits intoapple:mainfrom
Open
Implement next(isolation:) in AsyncAdjacentPairsSequence#390alex-waldron wants to merge 4 commits intoapple:mainfrom
alex-waldron wants to merge 4 commits intoapple:mainfrom
Conversation
The next(isolation:) method allows the iterator to inherit the caller's isolation context, avoiding unnecessary isolation hops.
alex-waldron
force-pushed
the
implement-isolated-next-adjacent-pairs
branch
from
1ca8823 to
0f896c5
Compare
phausler
reviewed
Jan 26, 2026
|
|
||
| import XCTest | ||
| import AsyncAlgorithms | ||
| import Observation |
Member
There was a problem hiding this comment.
I think the test does not really need Observations to work - we have other things that dont have this added dependency.
Author
There was a problem hiding this comment.
Nope it doesn't. Its just what I was using when I discovered the issue. I replaced it with an existing test async sequence in 425dba6
Member
|
@swift-ci please test |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The next(isolation:) method allows the iterator to inherit the caller's isolation context, avoiding unnecessary isolation hops.