Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add localisation support for strings #247

Open
wants to merge 12 commits into
base: main
Choose a base branch
from

Conversation

bitigchi
Copy link

@bitigchi bitigchi commented Oct 6, 2020

Checklist

  • I've added at least one test that validates that my change is working, if appropriate
  • I've followed the code style of the rest of the project
  • I've read the Contribution Guidelines
  • I've updated the documentation if necessary

@mpapple-swift
Copy link

Providing the ability to localize command line tools/apps is a great idea and I don't wish to dampen your enthusiasm for this effort. I do, however, wish to pose an open question for discussion: .lproj resources are unique to Apple/Darwin platforms - is this an appropriate design for a library that is cross-platform in nature? Of the leading (non-Swift) libraries I surveyed, none of them offers localization capabilities, so leveraging the Apple/Darwin approach is as good as any. But it is a fair question to ascertain if there are any reservations from developers on Linux or Windows? Otherwise, I'm +1 on adding this capability absent reservations about the design/implementation.

@bitigchi
Copy link
Author

bitigchi commented Oct 7, 2020

I personally think .lproj files are fine. There are already different approaches to this in other platforms, like how gettext handles stuff. However, it would be neat to have the framework automatically handle the localisations in bundle, like it does with regular AppKit/UIKit/SwiftUI apps, without having to manually locate .lproj files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants