Skip to content

Commit d9182a9

Browse files
authored
Suppress retroactive conformance errors (#603)
These warnings are showing up in tests about types and protocols that are defined within this package, so they don't pose a problem for future library evolution. Instead of using the `@retroactive` attribute, which isn't supported by older compilers, this change fully qualifies the type and protocol in the relevant conformance declarations, which suppresses the issue. Re: https://github.com/apple/swift-evolution/blob/main/proposals/0364-retroactive-conformance-warning.md
1 parent c769981 commit d9182a9

File tree

3 files changed

+3
-3
lines changed

3 files changed

+3
-3
lines changed

Tests/ArgumentParserUnitTests/HelpGenerationTests.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ import ArgumentParserTestHelpers
1616
final class HelpGenerationTests: XCTestCase {
1717
}
1818

19-
extension URL: ExpressibleByArgument {
19+
extension Foundation.URL: ArgumentParser.ExpressibleByArgument {
2020
public init?(argument: String) {
2121
guard let url = URL(string: argument) else {
2222
return nil

Tests/ArgumentParserUnitTests/SplitArgumentTests.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ import XCTest
1313
@testable import ArgumentParser
1414
import ArgumentParserTestHelpers
1515

16-
extension SplitArguments.InputIndex: ExpressibleByIntegerLiteral {
16+
extension ArgumentParser.SplitArguments.InputIndex: Swift.ExpressibleByIntegerLiteral {
1717
public init(integerLiteral value: Int) {
1818
self.init(rawValue: value)
1919
}

Tools/generate-manual/Extensions/Date+ExpressibleByArgument.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212
import ArgumentParser
1313
import Foundation
1414

15-
extension Date: ExpressibleByArgument {
15+
extension Foundation.Date: ArgumentParser.ExpressibleByArgument {
1616
// parsed as `yyyy-mm-dd`
1717
public init?(argument: String) {
1818
// ensure the input argument is composed of exactly 3 components separated

0 commit comments

Comments
 (0)