Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Add "--unet-support-both" option to torch2coreml #159

Open
jrittvo opened this issue Apr 20, 2023 · 0 comments
Open

Feature Request: Add "--unet-support-both" option to torch2coreml #159

jrittvo opened this issue Apr 20, 2023 · 0 comments

Comments

@jrittvo
Copy link

jrittvo commented Apr 20, 2023

It seems that an app implementation can choose between using Unet.mlmodelc or ControlledUnet.mlmodelc at model loading, or perhaps at inference run time. This means that a single model folder can contain both Unet versions, rather than needing what would appear to be a largely duplicative second model folder. As such, it would be convenient if torch2coreml had an argument to convert both Unet versions in a single run. Presently, one run is required to obtain eachUnet type, although the second run can be set to only provide the ControlledUnet.mlmodelc. If the user does not anticipate needing both Unet types, they would not use this added argument.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant