Fix tests where backup agents are not resumed

Also consolidate key updates for pausing backups.

20250520-175022-jzhou-10106ade7e0ad74f

100k backup 20250520-175208-jzhou-15255334e0c57eec

Author: jzhou77

fdbclient/FileBackupAgent.actor.cpp

@@ -7274,22 +7274,23 @@ class FileBackupAgentImpl {
 
 	ACTOR static Future<Void> changePause(FileBackupAgent* backupAgent, Database db, bool pause) {
 		state Reference<ReadYourWritesTransaction> tr(new ReadYourWritesTransaction(db));
-		state Future<Void> change = backupAgent->taskBucket->changePause(db, pause);
 
 		loop {
 			tr->setOption(FDBTransactionOptions::ACCESS_SYSTEM_KEYS);
 			tr->setOption(FDBTransactionOptions::LOCK_AWARE);
 			tr->setOption(FDBTransactionOptions::PRIORITY_SYSTEM_IMMEDIATE);
 
 			try {
+				// This is the pause key is in the task bucket, for backup agents
+				backupAgent->taskBucket->changePause(tr, pause);
+				// This is backup workers' pause key.
 				tr->set(backupPausedKey, pause ? "1"_sr : "0"_sr);
 				wait(tr->commit());
 				break;
 			} catch (Error& e) {
 				wait(tr->onError(e));
 			}
 		}
-		wait(change);
 		TraceEvent("FileBackupAgentChangePaused").detail("Action", pause ? "Paused" : "Resumed");
 		return Void();
 	}

fdbserver/workloads/Backup.actor.cpp

@@ -118,11 +118,9 @@ struct BackupWorkload : TestWorkload {
 
 	// Resume the backup agent if it is paused
 	ACTOR static Future<Void> resumeAgent(Database cx, FileBackupAgent* backupAgent) {
-		bool active = wait(backupAgent->checkActive(cx));
-		if (!active) {
-			wait(backupAgent->changePause(cx, false));
-			TraceEvent("BW_AgentResumed").log();
-		}
+		TraceEvent("BW_AgentResuming").log();
+		wait(backupAgent->changePause(cx, false));
+		TraceEvent("BW_AgentResumed").log();
 		return Void();
 	}
 

fdbserver/workloads/Restore.actor.cpp

@@ -111,10 +111,9 @@ struct RestoreWorkload : TestWorkload {
 
 	// Resume the backup agent if it is paused
 	ACTOR static Future<Void> resumeAgent(Database cx, FileBackupAgent* backupAgent) {
-		bool active = wait(backupAgent->checkActive(cx));
-		if (!active) {
-			wait(backupAgent->changePause(cx, false));
-		}
+		TraceEvent("RW_AgentResuming").log();
+		wait(backupAgent->changePause(cx, false));
+		TraceEvent("RW_AgentResumed").log();
 		return Void();
 	}
 
@@ -137,7 +136,8 @@ struct RestoreWorkload : TestWorkload {
 		state DatabaseConfiguration config = wait(getDatabaseConfiguration(cx));
 		TraceEvent("RW_Arguments")
 		    .detail("BackupTag", printable(self->backupTag))
-		    .detail("PerformRestore", self->performRestore);
+		    .detail("PerformRestore", self->performRestore)
+		    .detail("AllowPauses", self->allowPauses);
 
 		if (self->allowPauses && BUGGIFY) {
 			cp = changePaused(cx, &backupAgent);