Vminitd: Rework ManagedContainer #168
Merged
+36
−52
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This gets rid of some design decisions that I was not fond of. This changes the process start for both execs and the init process to happen internally in the object, as well as makes it so that all exec functionalities can happen on the container object itself. This allows us to get rid of the `if request.id == containerID` branches in the rpcs, and handle this entirely in the object itself using its own internal state.
crosbymichael
approved these changes
Jun 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This gets rid of some design decisions that I was not fond of. This changes the process start for both execs and the init process to happen internally in the object, as well as makes it so that all exec functionalities can happen on the container object itself. This allows us to get rid of the
if request.id == containerIDbranches in the rpcs, and handle this entirely in the object itself using its internal state.The existing integration tests should stress this just fine I believe.