Merge branch 'main' of https://github.com/DSS3113/container into custom-mac-address

Author: DSS3113

Sources/ContainerClient/Core/ClientContainer.swift

@@ -277,7 +277,7 @@ extension ClientContainer {
             guard let fds else {
                 throw ContainerizationError(
                     .internalError,
-                    message: "No log fds returned"
+                    message: "no log fds returned"
                 )
             }
             return fds

Sources/ContainerClient/Core/ClientImage.swift

@@ -41,7 +41,7 @@ public struct ClientImage: Sendable {
     /// Returns the underlying OCI index for the image.
     public func index() async throws -> Index {
         guard let content: Content = try await contentStore.get(digest: description.digest) else {
-            throw ContainerizationError(.notFound, message: "Content with digest \(description.digest)")
+            throw ContainerizationError(.notFound, message: "content with digest \(description.digest)")
         }
         return try content.decode()
     }
@@ -53,10 +53,10 @@ public struct ClientImage: Sendable {
             desc.platform == platform
         }
         guard let desc else {
-            throw ContainerizationError(.unsupported, message: "Platform \(platform.description)")
+            throw ContainerizationError(.unsupported, message: "platform \(platform.description)")
         }
         guard let content: Content = try await contentStore.get(digest: desc.digest) else {
-            throw ContainerizationError(.notFound, message: "Content with digest \(desc.digest)")
+            throw ContainerizationError(.notFound, message: "content with digest \(desc.digest)")
         }
         return try content.decode()
     }
@@ -66,7 +66,7 @@ public struct ClientImage: Sendable {
         let manifest = try await self.manifest(for: platform)
         let desc = manifest.config
         guard let content: Content = try await contentStore.get(digest: desc.digest) else {
-            throw ContainerizationError(.notFound, message: "Content with digest \(desc.digest)")
+            throw ContainerizationError(.notFound, message: "content with digest \(desc.digest)")
         }
         return try content.decode()
     }
@@ -83,7 +83,7 @@ public struct ClientImage: Sendable {
         guard let manifest = index.manifests.first else {
             throw ContainerizationError(
                 .internalError,
-                message: "Failed to resolve indirect index \(self.digest): no manifests found"
+                message: "failed to resolve indirect index \(self.digest): no manifests found"
             )
         }
         return manifest
@@ -188,7 +188,7 @@ extension ClientImage {
     public static func get(reference: String) async throws -> ClientImage {
         let all = try await self.list()
         guard let found = try self._search(reference: reference, in: all) else {
-            throw ContainerizationError(.notFound, message: "Image with reference \(reference)")
+            throw ContainerizationError(.notFound, message: "image with reference \(reference)")
         }
         return found
     }
@@ -226,7 +226,7 @@ extension ClientImage {
 
         let reference = try self.normalizeReference(reference)
         guard let host = try Reference.parse(reference).domain else {
-            throw ContainerizationError(.invalidArgument, message: "Could not extract host from reference \(reference)")
+            throw ContainerizationError(.invalidArgument, message: "could not extract host from reference \(reference)")
         }
 
         request.set(key: .imageReference, value: reference)
@@ -320,7 +320,7 @@ extension ClientImage {
         let request = Self.newRequest(.imagePush)
 
         guard let host = try Reference.parse(reference).domain else {
-            throw ContainerizationError(.invalidArgument, message: "Could not extract host from reference \(reference)")
+            throw ContainerizationError(.invalidArgument, message: "could not extract host from reference \(reference)")
         }
         request.set(key: .imageReference, value: reference)
 

Sources/ContainerClient/Core/ClientKernel.swift

@@ -74,7 +74,7 @@ extension ClientKernel {
         do {
             let reply = try await client.send(message)
             guard let kData = reply.dataNoCopy(key: .kernel) else {
-                throw ContainerizationError(.internalError, message: "Missing kernel data from XPC response")
+                throw ContainerizationError(.internalError, message: "missing kernel data from XPC response")
             }
 
             let kernel = try JSONDecoder().decode(Kernel.self, from: kData)

Sources/ContainerClient/ExitMonitor.swift

@@ -76,7 +76,7 @@ public actor ExitMonitor {
             throw ContainerizationError(.invalidState, message: "ExitMonitor not setup for process \(id)")
         }
         guard self.runningTasks[id] == nil else {
-            throw ContainerizationError(.invalidState, message: "Already have a running task tracking process \(id)")
+            throw ContainerizationError(.invalidState, message: "already have a running task tracking process \(id)")
         }
         self.runningTasks[id] = Task {
             do {

Sources/ContainerClient/Parser.swift

@@ -413,7 +413,7 @@ public struct Parser {
                 case "volume":
                     // For volume mounts, validate as volume name
                     guard VolumeStorage.isValidVolumeName(val) else {
-                        throw ContainerizationError(.invalidArgument, message: "Invalid volume name '\(val)': must match \(VolumeStorage.volumeNamePattern)")
+                        throw ContainerizationError(.invalidArgument, message: "invalid volume name '\(val)': must match \(VolumeStorage.volumeNamePattern)")
                     }
 
                     // This is a named volume
@@ -488,7 +488,7 @@ public struct Parser {
             guard src.hasPrefix("/") else {
                 // Named volume - validate name syntax only
                 guard VolumeStorage.isValidVolumeName(src) else {
-                    throw ContainerizationError(.invalidArgument, message: "Invalid volume name '\(src)': must match \(VolumeStorage.volumeNamePattern)")
+                    throw ContainerizationError(.invalidArgument, message: "invalid volume name '\(src)': must match \(VolumeStorage.volumeNamePattern)")
                 }
 
                 // This is a named volume

Sources/ContainerClient/RequestScheme.swift

@@ -33,7 +33,7 @@ public enum RequestScheme: String, Sendable {
         case RequestScheme.auto.rawValue:
             self = .auto
         default:
-            throw ContainerizationError(.invalidArgument, message: "Unsupported scheme \(rawValue)")
+            throw ContainerizationError(.invalidArgument, message: "unsupported scheme \(rawValue)")
         }
     }
 
@@ -42,7 +42,7 @@ public enum RequestScheme: String, Sendable {
     /// - Returns: RequestScheme
     package func schemeFor(host: String) throws -> Self {
         guard host.count > 0 else {
-            throw ContainerizationError(.invalidArgument, message: "Host cannot be empty")
+            throw ContainerizationError(.invalidArgument, message: "host cannot be empty")
         }
         switch self {
         case .http, .https:

Sources/ContainerClient/SandboxClient.swift

@@ -281,7 +281,7 @@ extension XPCMessage {
         guard let id else {
             throw ContainerizationError(
                 .invalidArgument,
-                message: "No id"
+                message: "no id"
             )
         }
         return id
@@ -292,7 +292,7 @@ extension XPCMessage {
         guard let data else {
             throw ContainerizationError(
                 .invalidArgument,
-                message: "No state data returned"
+                message: "no state data returned"
             )
         }
         return try JSONDecoder().decode(SandboxSnapshot.self, from: data)

Sources/ContainerClient/Utility.swift

@@ -287,7 +287,7 @@ public struct Utility {
         let s: SystemPlatform = .current
         if let userKernel = management.kernel {
             guard FileManager.default.fileExists(atPath: userKernel) else {
-                throw ContainerizationError(.notFound, message: "Kernel file not found at path \(userKernel)")
+                throw ContainerizationError(.notFound, message: "kernel file not found at path \(userKernel)")
             }
             let p = URL(filePath: userKernel)
             return .init(path: p, platform: s)

Sources/ContainerCommands/Image/ImageInspect.swift

@@ -48,7 +48,7 @@ extension Application {
                 print(try printable.jsonArray())
             }
             if notFound.count > 0 {
-                throw ContainerizationError(.notFound, message: "Images: \(notFound.joined(separator: "\n"))")
+                throw ContainerizationError(.notFound, message: "images: \(notFound.joined(separator: "\n"))")
             }
         }
     }

Sources/ContainerCommands/Image/ImageList.swift

@@ -146,11 +146,11 @@ extension Application {
 
         static func validate(options: ListImageOptions) throws {
             if options.quiet && options.verbose {
-                throw ContainerizationError(.invalidArgument, message: "Cannot use flag --quite and --verbose together")
+                throw ContainerizationError(.invalidArgument, message: "cannot use flag --quite and --verbose together")
             }
             let modifier = options.quiet || options.verbose
             if modifier && options.format == .json {
-                throw ContainerizationError(.invalidArgument, message: "Cannot use flag --quite or --verbose along with --format json")
+                throw ContainerizationError(.invalidArgument, message: "cannot use flag --quite or --verbose along with --format json")
             }
         }