better handling of invocationtargetexception

[SrinivasanTarget]

Change list

Better handling of invocationtargetexception thrown during creating session

Thanks @iddol.

Types of changes

What types of changes are you proposing/introducing to Java client?
Put an x in the boxes that apply

• No changes in production code.
• Bugfix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)

@mykola-mokhnach FYI

[mykola-mokhnach]

why not to use format specifiers for both arguments?

[mykola-mokhnach]

Also, it might be handy to pass the original exception as cause constructor argument, so it would be easier to debug it.

[SrinivasanTarget]

Throwable cause = e.getCause();
                        throw new SessionNotCreatedException(
                                format("Unable to create new remote session. desired capabilities = %s"
                                        + "and reason is %s", desired, cause != null ? cause.getMessage() : null,
                                        e.getTargetException()));

@mykola-mokhnach Do you mean it this way?

[mykola-mokhnach]

almost. It's just instead of setting reason to null if cause is null you set it to the original exception value

[mykola-mokhnach]

also SessionNotCreatedException has the second constructor where one can provide the cause:

SessionNotCreatedException(String msg, Throwable cause)

[SrinivasanTarget]

Yeah i used the same constructor above.

[mykola-mokhnach]

can it be that getCause returns null?

[mykola-mokhnach]

desired capabilities = %s -> Desired capabilities: %s