-
-
Notifications
You must be signed in to change notification settings - Fork 765
feat: Proxy commands issues via RemoteWebElement #2311
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
+291
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
valfirst
reviewed
Jul 1, 2025
src/main/java/io/appium/java_client/proxy/RemoteWebElementListener.java
Outdated
Show resolved
Hide resolved
src/main/java/io/appium/java_client/proxy/RemoteWebElementListener.java
Outdated
Show resolved
Hide resolved
src/test/java/io/appium/java_client/proxy/ProxyHelpersTest.java
Outdated
Show resolved
Hide resolved
I believe it's a new feature, not a fix |
src/test/java/io/appium/java_client/proxy/ProxyHelpersTest.java
Outdated
Show resolved
Hide resolved
src/main/java/io/appium/java_client/proxy/RemoteWebElementListener.java
Outdated
Show resolved
Hide resolved
src/main/java/io/appium/java_client/proxy/WebDriverListener.java
Outdated
Show resolved
Hide resolved
src/main/java/io/appium/java_client/proxy/WebDriverListener.java
Outdated
Show resolved
Hide resolved
src/test/java/io/appium/java_client/proxy/ProxyHelpersTest.java
Outdated
Show resolved
Hide resolved
mykola-mokhnach
approved these changes
Jul 2, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the great work @pujagani
valfirst
requested changes
Jul 2, 2025
src/main/java/io/appium/java_client/proxy/ElementAwareWebDriverListener.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Valery Yatsynovich <valeryyatsynovich@gmail.com>
…appium-java-client into proxy-remotewebelement
@valfirst I made the changes, let me know if it looks alright now. |
valfirst
approved these changes
Jul 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2239
Change list
Types of changes
What types of changes are you proposing/introducing to Java client?
Put an
x
in the boxes that applyDetails
Commands called on WebElements instances are not proxied when using
createProxy
. Since all webdriver calls route through RemoteWebDriver'sexecute
method, which is markedprotected
, that call is not intercepted. Commands likefindElement
return a WebElement instance, and when commands likeclick
are called on it, there is no way to intercept them.The changes in this PR address the issue by creating a proxy for the RemoteWebElement and assigning
id
andparent
properties for calls whose result is an instance of RemoteWebElement, thereby intercepting these calls without requiring code changes from the user's end.