ci: Run tests against latest Selenium release #1978
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
valfirst
requested review from
mykola-mokhnach,
SrinivasanTarget and
saikrishna321
as code owners
|
@mykola-mokhnach @saikrishna321 @SrinivasanTarget could you please review the changes? |
|
LGTM |
| prefer "${seleniumVersion}" | ||
| } | ||
| } | ||
| testImplementation platform(group: 'org.seleniumhq.selenium', name: 'selenium-bom', version: '4.11.0') |
There was a problem hiding this comment.
are you sure you want to merge this? how about seleniumVersion then?
There was a problem hiding this comment.
seleniumVersion will be used in published POM and will declare minimal support version of Selenium
as for the test stage Gradle will resolve conflicts and will pick up the latest version (== declared in test scope), so all tests will be run against the latest version
There was a problem hiding this comment.
if this is only for tests then should be ok
mykola-mokhnach
approved these changes
Aug 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change list
Make sure to run tests against the latest Selenium release.
Types of changes
What types of changes are you proposing/introducing to Java client?
Put an
xin the boxes that applyDetails
in this way it will be possible to test integration with latest Selenium clients in automated way