Change the java version #1631
Merged
Change the java version #1631
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
on my machine, Maven defaults to 1.7, which doesn't work.
asolntsev
approved these changes
Jan 12, 2022
docs/Installing-the-project.md
Outdated
| If you haven't already, change the Java version: | ||
| ``` | ||
| <properties> | ||
| <maven.compiler.source>11</maven.compiler.source> |
There was a problem hiding this comment.
the minimum supported one is actually 1.8
There was a problem hiding this comment.
alright, i'll change it to 1.8
|
Thanks, could you please sign the CLA? |
|
@mykola-mokhnach i'm waiting for LFX to confirm what they need my home address for. |
|
@mykola-mokhnach signed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change list
on my machine, Maven defaults to 1.7, which doesn't work. add instructions to update the version in
pom.xml.Types of changes
Details
on my Maven (and I think everyone's?), the default java.compiler.source and java.compiler.target are 1.7, which doesn't work on my machine.